Skip to content

Conversation

@Ambika-Sony
Copy link

@Ambika-Sony Ambika-Sony commented Jan 26, 2026

Description

This PR addresses the inconsistency between the Frontend UI validation and the Backend/Database default credentials, which is now tracked under WEB-628.

Previously, the UI enforced a 12-character minimum password length, which blocked access for the default system credential 'password' (8 characters). I have updated the validator to allow an 8-character minimum to match these default settings and improve the onboarding experience for new developers.

Related issues and discussion
Fixes #WEB-628
(Note: Originally reported as FINERACT-2451; moved to the MifosForge WEB board per mentor guidance).

Screenshots
Before (Bug)
The UI blocked the login button because the password 'password' did not meet the 12-character requirement.
Screenshot 2026-01-26 102340

After (Fixed)
The UI now accepts the 8-character default password, allowing successful login to the Mifos dashboard.
Screenshot 2026-01-26 110631

Checklist
[x ] If you have multiple commits please combine them into one commit by squashing them.

[x] Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md

@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

The minimum password validation length in the login form's password control was reduced from 8 to 4 characters. This is a single-line validation rule modification with no changes to control flow or exported entity signatures.

Changes

Cohort / File(s) Summary
Password Validation Update
src/app/login/login-form/login-form.component.ts
Reduced minimum password length requirement from 8 to 4 characters in the password validator

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • IOhacker
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions 'Standardized login password minimum length validation' but the actual change lowered the minimum from 12 to 4 characters, not standardized it to a specific value. Additionally, the title says 'WEB-628' while the PR objectives reference 'FINERACT-2451', creating a mismatch. The title is partially related but misleading about what 'standardized' means in this context. Update the title to accurately reflect the change, such as 'WEB-628: Lower login password minimum length validation from 12 to 4 characters' or 'WEB-628: Reduce minimum password length requirement to 4 characters'. Also verify the correct issue identifier (WEB-628 vs FINERACT-2451) matches across the PR.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/app/login/login-form/login-form.component.ts (1)

125-130: Align password minimum length with the PR objective (8 chars).

The PR objective explicitly targets a minimum length of 8 to match the default credential "password". Setting 4 here undercuts that requirement and weakens password policy. Please update to 8 so UI validation matches the intended standard.

🔧 Proposed fix
       password: [
         '',
         [
           Validators.required,
-          Validators.minLength(4)
+          Validators.minLength(8)
         ]
       ],

@Ambika-Sony
Copy link
Author

Ambika-Sony commented Jan 26, 2026 via email

@Ambika-Sony Ambika-Sony changed the title FINERACT-2451: Standardized password minLength to 8 WEB-628: Standardized login password minimum length validation Jan 26, 2026
@Ambika-Sony Ambika-Sony force-pushed the fix/password-validation-FINERACT-2451 branch from f9bd956 to d605218 Compare January 27, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant