core: add focused diagnostics for remote compaction overflows by charley-oai · Pull Request #11133 · openai/codex

charley-oai · 2026-02-09T02:01:39Z

Summary

add targeted remote-compaction failure diagnostics in compact_remote logging
log the specific values needed to explain overflow timing:
- last_api_response_total_tokens
- estimated_tokens_of_items_added_since_last_successful_api_response
- estimated_bytes_of_items_added_since_last_successful_api_response
- failing_compaction_request_body_bytes
simplify breakdown naming and remove last_api_response_total_bytes_estimate (it was an approximation and not useful for debugging)

Why

When compaction fails with context_length_exceeded, we need concrete, low-ambiguity numbers that map directly to:

what the API most recently reported, and
what local history added since then.

This keeps the failure logs actionable without adding broad, noisy metrics.

Testing

just fmt
cargo test -p codex-core

charley-oai · 2026-02-09T02:07:07Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9456959a82

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/compact_remote.rs

charley-oai · 2026-02-09T02:26:11Z

@codex review this

chatgpt-codex-connector · 2026-02-09T02:28:22Z

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-02-09T03:55:41Z

@codex review this

chatgpt-codex-connector · 2026-02-09T03:57:31Z

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/compact_remote.rs

codex-rs/core/src/context_manager/history.rs

codex-rs/core/src/state/session.rs

codex-rs/core/src/compact_remote.rs

charley-oai · 2026-02-09T18:23:18Z

@codex review this

chatgpt-codex-connector · 2026-02-09T18:29:52Z

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-02-09T19:09:39Z

@codex review this

chatgpt-codex-connector · 2026-02-09T19:13:05Z

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-02-09T20:35:45Z

@codex review this

chatgpt-codex-connector · 2026-02-09T20:37:42Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector bot reviewed Feb 9, 2026

View reviewed changes

codex-rs/core/src/compact_remote.rs Outdated Show resolved Hide resolved

jif-oai approved these changes Feb 9, 2026

View reviewed changes

pakrym-oai reviewed Feb 9, 2026

View reviewed changes

codex-rs/core/src/compact_remote.rs Outdated Show resolved Hide resolved

Base automatically changed from cc/compact-token-delta to main February 9, 2026 16:35

charley-oai added 19 commits February 9, 2026 10:24

core: log compaction payload and token usage breakdown on failure

7f80ada

core: simplify compaction failure usage breakdown logs

c81ddc9

core: align compaction byte metric with token approximation

08adc3a

core: rename model-visible byte estimator

bbd20cc

core: derive compaction failure bytes from serialized payload

8ff4c76

core: log compaction payload body at trace level

4329f11

core: log compaction model-visible bytes with shared estimator

03fee11

core: log all-history model-visible bytes for compaction debug

6f689c1

core: make model-visible byte folds more declarative

3be13a4

core: use try-future error mapping for compact failure logging

f8556dc

core: rename compact request logging payload struct

f828a3a

core: use i64 for token usage byte breakdown fields

7110012

core: inline all-history byte sum into usage breakdown

ace55ae

core: remove duplicate compaction payload body trace log

291fc51

core: inline compact error status mapping

6ce1cf2

core: remove redundant session token breakdown passthrough

e5325d2

core: inline post-model token and byte delta helpers

1e2da2c

core: use map-then-fold style for token sums

eedee73

core: use map-then-fold style for byte sums

dbd9e25

charley-oai force-pushed the cc/compact-failure-logging branch from 452af63 to dbd9e25 Compare February 9, 2026 18:24

charley-oai added 2 commits February 9, 2026 10:38

core: drop unused token breakdown import

28c0070

core tests: update history token delta assertions after helper inline

6a2b915

charley-oai added 5 commits February 9, 2026 11:37

Keep byte-length metrics as usize in token usage breakdown

13ea543

Make TotalTokenUsageBreakdown fields consistently i64

09b5821

Return model-visible byte estimates as i64

dab003b

Add i64 byte-to-token helper for history estimates

8c0b086

remove status code

7ee9e2b

charley-oai enabled auto-merge (squash) February 9, 2026 20:35

charley-oai disabled auto-merge February 9, 2026 20:35

Conversation

charley-oai commented Feb 9, 2026

Summary

Why

Testing

Uh oh!

charley-oai commented Feb 9, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Feb 9, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 9, 2026

Uh oh!

charley-oai commented Feb 9, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

charley-oai commented Feb 9, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 9, 2026

Uh oh!

charley-oai commented Feb 9, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 9, 2026

Uh oh!

charley-oai commented Feb 9, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants