Add riscv64, make Linux targets more explicit#98
Open
threexc wants to merge 2 commits intoopenai:mainfrom
Open
Add riscv64, make Linux targets more explicit#98threexc wants to merge 2 commits intoopenai:mainfrom
threexc wants to merge 2 commits intoopenai:mainfrom
Conversation
Specify the exact rustc target to be used by maturin, so that it is clear which target is used for a given arch. Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
maturin supports riscv64 (specifically, riscv64gc) as a target. Add that to the build matrix. Note that this inspires the previous commit to make things more explicit, as 'riscv64' is not a valid shorthand for the rustc target, but it is used in package names when uploaded to PyPI. Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
82de6ba to
f13e780
Compare
Author
|
Test CI run in my fork: https://github.com/threexc/harmony/actions/runs/22162002096/job/64081395980 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maturin supports riscv64 (specifically, riscv64gc) as a target. Add that to the build matrix. Note that this inspires the previous commit to make things more explicit, as 'riscv64' is not a valid shorthand for the rustc target, but it is used in package names when uploaded to PyPI.
Note that this is being done on behalf of the RISE Project to improve Python ecosystem support on riscv64 platforms.