Skip to content

Remove guard on windows when relying on h5py to provide h5 DLL#37

Merged
mgeplf merged 1 commit into
masterfrom
disable-win-h5-check
Mar 18, 2026
Merged

Remove guard on windows when relying on h5py to provide h5 DLL#37
mgeplf merged 1 commit into
masterfrom
disable-win-h5-check

Conversation

@mgeplf
Copy link
Copy Markdown
Collaborator

@mgeplf mgeplf commented Mar 18, 2026

No description provided.

@mgeplf mgeplf force-pushed the disable-win-h5-check branch from 40fac61 to d8827b2 Compare March 18, 2026 08:46
@mgeplf
Copy link
Copy Markdown
Collaborator Author

mgeplf commented Mar 18, 2026

According to #35 (comment)
this works.

It looks like the CI also used the new h5py wheel:

2026-03-18T08:54:37.7877325Z ##[group]Testing wheel...
2026-03-18T08:54:37.7877476Z 
2026-03-18T08:54:37.7880733Z + 'C:\hostedtoolcache\windows\Python\3.11.9\x64\python.exe' -sS 'C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\virtualenv-21.1.0.pyz' --activators= --no-periodic-update --pip=26.0.1 --no-setuptools --python 'C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.10.11\tools\python.exe' 'C:\Users\runneradmin\AppData\Local\Temp\cibw-run-la0ktc46\cp310-win_amd64\venv-test'
2026-03-18T08:54:38.5131062Z created virtual environment CPython3.10.11.final.0-64-x86_64 in 476ms
2026-03-18T08:54:38.5131933Z   creator CPython3Windows(dest=C:\Users\runneradmin\AppData\Local\Temp\cibw-run-la0ktc46\cp310-win_amd64\venv-test, clear=False, no_vcs_ignore=False, global=False)
2026-03-18T08:54:38.5132807Z   seeder FromAppData(download=False, pip=26.0.1, via=copy, app_data_dir=C:\Users\runneradmin\AppData\Local\pypa\virtualenv\Cache)
2026-03-18T08:54:38.5133325Z     added seed packages: pip==26.0.1
2026-03-18T08:54:38.5439103Z + where python
2026-03-18T08:54:38.5667700Z C:\Users\runneradmin\AppData\Local\Temp\cibw-run-la0ktc46\cp310-win_amd64\venv-test\Scripts\python.exe
2026-03-18T08:54:38.5675212Z C:\Users\runneradmin\AppData\Local\Temp\cibw-run-la0ktc46\cp310-win_amd64\build\venv\Scripts\python.exe
2026-03-18T08:54:38.5824351Z C:\hostedtoolcache\windows\Python\3.11.9\x64\python.exe
2026-03-18T08:54:38.5885330Z C:\hostedtoolcache\windows\Python\3.12.10\x64\python.exe
2026-03-18T08:54:38.6371388Z + pip install -r ./tests/requirement_tests.txt
2026-03-18T08:54:40.1118896Z Collecting h5py>=2.9.0 (from -r ./tests/requirement_tests.txt (line 1))
2026-03-18T08:54:40.2059117Z   Downloading h5py-3.16.0-cp310-cp310-win_amd64.whl.metadata (3.1 kB)

@mgeplf mgeplf requested a review from eleftherioszisis March 18, 2026 09:47
@mgeplf mgeplf merged commit 1ebd68d into master Mar 18, 2026
22 checks passed
@mgeplf mgeplf deleted the disable-win-h5-check branch March 18, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants