fix(repair): gracefully handle open-but-locked issues and PRs during apply runs#126
Open
AsishKumarDalal wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Overview of Changes
This PR resolves a critical resilience issue in the automated applicator worker (
scripts/apply-result.ts). Currently, when automated cleanup scripts run on stale or duplicate issues/PRs, they can fail catastrophically if they attempt to interact with locked conversations.🔍 The Problem
403 Forbiddenerror indicating the conversation is locked. Because these exceptions are not handled, they bubble up and crash the entire apply run.🛠️ Solution Implementation
We have introduced both proactive and reactive guards to handle locked conversations gracefully:
Proactive Lock Detection:
applyCloseActionandapplyMergeAction, we now inspectlive.lockedimmediately after fetching the target.live.locked === true, we gracefully skip the action, returning status"skipped"and reason"target is locked".Reactive Lock Resilience:
applyCloseAction, we wrappostIssueCommentandcloseIssueOrPullRequestinside atry-catchblock.applyMergeAction, we wrap theghWithRetry(mergeArgs)call in atry-catchblock.isLockedConversationCommentError(error)safety utility. If matched, we gracefully transform the 403 failure into a terminal"skipped"status and reason"target is locked (terminal 403)", preventing the entire script from crashing.This guarantees robust, non-crashing execution for scheduled workflow sweeps.