Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs cleanup by fixing formatting issues in error messages. The changes correct two error messages by adding missing spaces and fixing the order of variable/component names in the messages.
Key changes:
- Fixed missing spaces in error messages (e.g.,
'environment'cannot→'environment' cannot) - Corrected the order of variable and component names in one error message to properly show "variable 'X' in component 'Y'" instead of "variable 'Y' in component 'X'"
- Updated version to 0.20251204.0
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/sed/sedchangeattribute.cpp | Fixed spacing and corrected variable/component name order in two error message strings |
| tests/bindings/python/test_solver_coverage.py | Updated expected error messages to match the corrected source code messages |
| tests/bindings/javascript/solver.coverage.test.js | Updated expected error messages to match the corrected source code messages |
| tests/api/solver/coveragetests.cpp | Updated expected error messages to match the corrected source code messages |
| VERSION.txt | Bumped version number to 0.20251204.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Indeed, that version is not compatible with `sphinx-copybutton` and `sphinx-inline-tabs`.
agarny
force-pushed
the
cleaning-up
branch
4 times, most recently
from
842d15e to
52a8aee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.