Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refines interactive simulation UX and some widget internals by improving default UI JSON handling, simplifying Plotly axis configuration, and cleaning up UI terminology.
Changes:
- Add a computed default slider step for scalar inputs when no explicit step is provided.
- Refactor GraphPanel axis configuration types/structure.
- Improve interactive-mode defaults by seeding UI JSON with VOI output data and pass VOI id/name separately to the settings dialog; rename “Model inputs” to “Simulation inputs”.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/src/components/widgets/InputWidget.vue | Introduces computed step value for slider when stepValue is not provided. |
| src/renderer/src/components/widgets/GraphPanelWidget.vue | Refactors axis layout typing/configuration for Plotly. |
| src/renderer/src/components/views/SimulationExperimentView.vue | Seeds default UI JSON with VOI output data and passes VOI id/name to settings dialog. |
| src/renderer/src/components/dialogs/SimulationExperimentViewSettingsDialog.vue | Renames interactive “inputs” wording; adds voiId prop usage; adjusts defaults when adding plots/traces/data. |
| src/renderer/package.json | Bumps renderer package version. |
| package.json | Bumps root package version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/renderer/src/components/dialogs/SimulationExperimentViewSettingsDialog.vue
Show resolved
Hide resolved
…labels. Axis titles should have a bigger font than axis tick labels.
… as a simulation data when there is no UI JSON to start with.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.