read and write inputfiles in gui updated.

[Sierd]

No description provided.

[Copilot]

Pull request overview

This PR updates the functionality for reading and writing input files in the GUI, with a major refactoring of the configuration file writing logic to preserve structure and organization from the DEFAULT_CONFIG. The changes also reorganize the DEFAULT_CONFIG dictionary in constants.py with better sectioning and add support for handling empty strings and datetime patterns.

Changes:

• Refactored write_configfile to parse constants.py and preserve section structure with comments
• Reorganized DEFAULT_CONFIG into logical sections with descriptive headers
• Added empty string handling in utils and GUI for better input validation

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
aeolis/utils.py	Added empty string check to print_value function to treat empty strings like None
aeolis/inout.py	Complete rewrite of write_configfile to preserve section structure; added datetime pattern detection in parse_value
aeolis/hydro.py	Added empty check for external_vars before checking membership to prevent errors
aeolis/gui/application.py	Convert empty/whitespace-only strings to None when saving config
aeolis/constants.py	Major reorganization of DEFAULT_CONFIG with new section headers and logical grouping

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Unnecessary trailing space before the colon in the if statement. Remove the space between 'key])' and ':' for consistency with Python style guidelines.

Suggested change

	if key in DEFAULT_CONFIG and np.all(value == DEFAULT_CONFIG[key]) :
	if key in DEFAULT_CONFIG and np.all(value == DEFAULT_CONFIG[key]):

[Copilot]

Missing comma after 'mass' on line 206. This list should have commas separating all elements. The missing comma will cause a syntax error when Python tries to parse this configuration dictionary.

Suggested change

	'uth', 'mass'
	'uth', 'mass',

[Copilot]

Duplicate key 'method_vegetation' defined. This parameter is first defined on line 352 under the 'Vegetation (OLD)' section and then redefined on line 387 under the 'Grass vegetation model (new vegetation framework)' section. In Python dictionaries, duplicate keys cause the second value to overwrite the first, making line 352 ineffective. Consider removing the duplicate or using different key names if both are needed.

Suggested change

	'method_vegetation' : 'duran', # ['duran' | 'grass'] Vegetation formulation
	'method_vegetation_new' : 'duran', # ['duran' | 'grass'] Vegetation formulation

[Copilot]

Missing space between 'or' and the opening parenthesis. The condition should be written as 'or (' instead of 'or('. While Python will still parse this correctly, it violates PEP 8 style guidelines for spacing around operators.

Suggested change

	if not p['external_vars'] or('zs' not in p['external_vars']) :
	if not p['external_vars'] or ('zs' not in p['external_vars']) :

[Copilot]

Line 71 contains only whitespace with inconsistent indentation. This appears to be an unnecessary blank line within the if statement block. Remove this line or ensure consistent indentation.

Suggested change

[Copilot]

Duplicate key 'max_moist' defined. Line 337 has a comment marker 'NEWCH' suggesting it may be leftover from development. In Python dictionaries, duplicate keys will result in the second value overwriting the first, making line 337 have no effect. Remove the duplicate on line 337.

Suggested change

'max_moist' : 10., # NEWCH # [%] Moisture content (volumetric in percent) above which the threshold shear velocity is set to infinity (no transport, default value Delgado-Fernandez, 2010)

[Copilot]

Duplicate key 'veg_sigma' defined. This parameter is first defined on line 361 under the 'Vegetation (OLD)' section and then redefined on line 426 under the 'Grass vegetation model (new vegetation framework)' section. In Python dictionaries, duplicate keys cause the second value to overwrite the first. Consider removing the duplicate or using different key names if both are needed.

Suggested change

	'veg_sigma' : 0., # [-] Sigma in gaussian distrubtion of vegetation cover filter
	'veg_sigma_grass' : 0., # [-] Sigma in gaussian distribution of vegetation cover filter (grass model)

[Copilot]

Spelling error: 'distrubtion' should be 'distribution'. This typo appears in the comment describing the veg_sigma parameter.

Suggested change

	'veg_sigma' : 0., # [-] Sigma in gaussian distrubtion of vegetation cover filter
	'veg_sigma' : 0., # [-] Sigma in gaussian distribution of vegetation cover filter

[Copilot]

Using np.all for comparison may fail when value is None or a non-array type (e.g., string, bool, int). The code attempts to compare all values in the configuration, including None types, which will cause np.all to raise an error. Consider adding a type check or using a safer comparison method that handles scalars, None, and arrays appropriately.

[Copilot]

Using np.all for comparison may fail when value is None or a non-array type (e.g., string, bool, int). The code attempts to compare all values in the configuration, including None types, which will cause np.all to raise an error. Consider adding a type check or using a safer comparison method that handles scalars, None, and arrays appropriately.