feat: roles and permissions tab added by jesusbalderramawgu · Pull Request #107 · openedx/frontend-app-admin-console

jesusbalderramawgu · 2026-03-23T15:10:23Z

Description

PR to replace old Roles and permissions Tab for a new one, completely merged. It closes the task

Courses

Libraries

Roles and permissions Tabs merged
ButtonGroup added inside tab to select courses or libraries
messages fixed
hardcoded permissions added
component anchor to go to the top of the page when courses is selected
new path added to use this new tabs

openedx-webhooks · 2026-03-23T15:10:29Z

Thanks for the pull request, @jesusbalderramawgu!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2026-03-23T21:26:50Z

Codecov Report

❌ Patch coverage is 97.61905% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.37%. Comparing base (74ee431) to head (d4cb09d).
⚠️ Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
src/authz-module/index.tsx	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   95.18%   95.37%   +0.19%     
==========================================
  Files          45       49       +4     
  Lines         913      994      +81     
  Branches      181      193      +12     
==========================================
+ Hits          869      948      +79     
- Misses         42       44       +2     
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jesusbalderramawgu · 2026-03-24T15:39:32Z

src/authz-module/libraries-manager/messages.ts

+    defaultMessage: 'Course Roles',
+    description: 'Libraries AuthZ title for the course roles alert',
+  },
+  'library.authz.tabs.permissionsRoles.courses.alert.description': {


this description is gonna change, waiting for the final text

jesusbalderramawgu · 2026-03-24T15:39:42Z

src/authz-module/libraries-manager/messages.ts

+    defaultMessage: 'This list shows the permissions currently available in Authoring Studio. Some roles may grant additional permissions manages outside this interface.',
+    description: 'Libraries AuthZ description for the course roles alert',
+  },
+  'library.authz.tabs.permissionsRoles.courses.alert.link': {


this link is gonna change, waiting for the final text

arbrandes

This is purely a code review: I did not test it.

src/authz-module/libraries-manager/constants.ts

arbrandes · 2026-03-25T16:52:03Z

src/authz-module/courses/constants.ts

+      CONTENT_COURSE_PERMISSIONS.VIEW_COURSE_FILES,
+      CONTENT_COURSE_PERMISSIONS.VIEW_COURSE_FILES,


Duplicated.

src/authz-module/courses/constants.ts

arbrandes · 2026-03-25T16:55:00Z

src/authz-module/roles-permissions/RolesPermissions.tsx

+  const [active, setActive] = useState('courses');
+
+  const [libraryPermissionsByResource] = useMemo(() => {
+    if (!rolesLibraryObject && !libraryPermissions && !libraryResourceTypes) { return [null, null]; }


First: these are constants. Why are we guarding against their non-existence?

Second: If they're dynamic, the checks should be ||, not &&.

I copied this function form another file and at first I thought it was going to be dynamic, I forgot to delete it.
it is fixed now!

arbrandes · 2026-03-25T16:59:37Z

src/authz-module/roles-permissions/RolesPermissions.tsx

+            onClick={() => setActive('courses')}
+            variant={`${active === 'courses' ? 'primary' : 'outline-primary'}`}
+          >
+            Courses


Needs internationalization.

done, thanks!

arbrandes · 2026-03-25T16:59:52Z

src/authz-module/roles-permissions/RolesPermissions.tsx

+            onClick={() => setActive('libraries')}
+            variant={`${active === 'libraries' ? 'primary' : 'outline-primary'}`}
+          >
+            Libraries


Needs internationalization.

done, thanks!

arbrandes · 2026-03-25T17:00:34Z

src/authz-module/roles-permissions/RolesPermissions.tsx

+                    <span><span className="font-weight-bold">Note:</span>{intl.formatMessage(messages['library.authz.tabs.permissionsRoles.courses.alert.description'])}</span>
+                  </div>
+                  <div className="col col-5">
+                    <Hyperlink className="d-block text-right h5 font-weight-normal" destination="." target="_blank" showLaunchIcon={false} isInline>


Is destination="." intentional?

yes, well I'm still waiting for the final texts here, maybe we don't need a Hyperink either but I don't know yet

This is the url: https://docs.openedx.org/en/latest/educators/references/course_development/course_team_roles.html

arbrandes · 2026-03-25T17:06:17Z

src/authz-module/components/AnchorButton.tsx

+
+  useEffect(() => {
+    const handleScroll = () => {
+      const scrollTop = window.pageYOffset || document.documentElement.scrollTop;


pageYOffset is deprecated. We should be using scrollY as the first option.

Regarding the fallback documentElement.scrollTop, there's no need for it. We don't support IE. (See the browsers we support here.

thank you, this was fixed!

src/authz-module/components/PermissionTable.tsx

jacobo-dominguez-wgu · 2026-03-25T22:46:01Z

src/authz-module/roles-permissions/RolesPermissions.tsx

+                <div className="row align-items-center">
+                  <div className="col col-7">
+                    <p className="text-primary font-weight-bold h4">{intl.formatMessage(messages['library.authz.tabs.permissionsRoles.courses.alert.title'])}</p>
+                    <span><span className="font-weight-bold">Note:</span>{intl.formatMessage(messages['library.authz.tabs.permissionsRoles.courses.alert.description'])}</span>


"Note:" needs i18n

done, thanks!

src/authz-module/components/PermissionTable.tsx

jacobo-dominguez-wgu · 2026-03-25T22:53:23Z

src/authz-module/components/AnchorButton.test.tsx

@@ -0,0 +1,59 @@
+import { renderWrapper } from '@src/setupTest';
+import { fireEvent, waitFor } from '@testing-library/react';


Do not use fireEvent, use userEvent instead

updated, thanks!

src/authz-module/roles-permissions/RolesPermissions.test.tsx

src/authz-module/roles-permissions/RolesPermissions.tsx

jacobo-dominguez-wgu · 2026-03-25T22:58:29Z

src/authz-module/roles-permissions/RolesPermissions.tsx

+              <PermissionTable
+                permissionsTable={CoursePermissionsByResource}
+                roles={rolesObject}
+                title="Course Roles"


updated, thanks!

src/authz-module/constants.ts

feat: roles and permissions tab added

db6f34c

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 23, 2026

openedx-webhooks added this to Contributions Mar 23, 2026

github-project-automation bot moved this to Needs Triage in Contributions Mar 23, 2026

mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Mar 23, 2026

mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 23, 2026

feat: refactor to create new path for roles permissions tab

cdf7208

jesusbalderramawgu marked this pull request as draft March 23, 2026 18:09

jesusbalderramawgu added 4 commits March 23, 2026 13:06

feat: icons added to roles

ae13f9b

feat: refactor in roles permissions tabs

144e7a8

chore: lint fix

165bccb

fix: imports

fd84286

jesusbalderramawgu added 4 commits March 23, 2026 16:46

feat: test added for new components

5ea04eb

feat: tests improved and texts updated

f004fb5

fix: removed unnecessary code

40eca19

fix: authzhome test fixed

023970b

jesusbalderramawgu commented Mar 24, 2026

View reviewed changes

jesusbalderramawgu marked this pull request as ready for review March 24, 2026 15:44

jesusbalderramawgu requested review from arbrandes and jacobo-dominguez-wgu March 25, 2026 14:09

arbrandes requested changes Mar 25, 2026

View reviewed changes

jesusbalderramawgu added 3 commits March 25, 2026 15:25

chore: fix texts and removed unnecessary validations

3517c50

fix: catch all route added

ffeb98b

feat: more tests added to anchor button

91f296d

jesusbalderramawgu requested a review from arbrandes March 25, 2026 22:24

jacobo-dominguez-wgu reviewed Mar 25, 2026

View reviewed changes

src/authz-module/components/PermissionTable.tsx Outdated Show resolved Hide resolved

jacobo-dominguez-wgu reviewed Mar 25, 2026

View reviewed changes

src/authz-module/roles-permissions/RolesPermissions.test.tsx Outdated Show resolved Hide resolved

chore: aria labels updated

90390e6

jacobo-dominguez-wgu reviewed Mar 25, 2026

View reviewed changes

src/authz-module/roles-permissions/RolesPermissions.tsx Outdated Show resolved Hide resolved

jacobo-dominguez-wgu reviewed Mar 25, 2026

View reviewed changes

src/authz-module/constants.ts Outdated Show resolved Hide resolved

jesusbalderramawgu added 2 commits March 25, 2026 17:06

chore: missing i18n added, tests updated

bdf0e78

chore: unnecessary path removed

d4cb09d

		CONTENT_COURSE_PERMISSIONS.VIEW_COURSE_FILES,
		CONTENT_COURSE_PERMISSIONS.VIEW_COURSE_FILES,

		@@ -0,0 +1,59 @@
		import { renderWrapper } from '@src/setupTest';
		import { fireEvent, waitFor } from '@testing-library/react';

Conversation

jesusbalderramawgu commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

openedx-webhooks commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arbrandes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arbrandes Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jesusbalderramawgu commented Mar 23, 2026 •

edited

Loading

openedx-webhooks commented Mar 23, 2026 •

edited

Loading

codecov bot commented Mar 23, 2026 •

edited

Loading

arbrandes Mar 25, 2026 •

edited

Loading