Skip to content

Modifications on the authz title(header) component#99

Merged
arbrandes merged 1 commit intoopenedx:masterfrom
WGU-Open-edX:header-modifications
Mar 17, 2026
Merged

Modifications on the authz title(header) component#99
arbrandes merged 1 commit intoopenedx:masterfrom
WGU-Open-edX:header-modifications

Conversation

@jacobo-dominguez-wgu
Copy link
Contributor

Description

Updating app title (header) to match new design.

Removing the allow public read switch. (Moved to studio openedx/frontend-app-authoring#2942)
Updated assign role button text.
Title and subtitle appears in the same line.

Resolves #94

On team members table:
image

On specific user view:
image

Testing instructions

Case 1:

  • Go to the admin console for a specific library http://apps.local.openedx.io:2025/admin-console/authz/libraries/
  • The "Allow public read" switch on the header must not be present on the header.
  • The assign role button text must be: "+ Assign role"
  • The title and subtitle must be on the same line with a vertical line separator (App title and library id).

Case 1:

  • Go to the admin console for a specific library http://apps.local.openedx.io:2025/admin-console/authz/libraries/
  • On the team members table select a user and click on the edit icon.
  • Once on the specific user view check for:
  • The assign role button text must be: "+ Add new role"
  • The title and subtitle must be on the same line with a vertical line separator (username and email).

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Mar 13, 2026
@openedx-webhooks
Copy link

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.18%. Comparing base (2ac818f) to head (ed3da72).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   95.15%   95.18%   +0.02%     
==========================================
  Files          46       45       -1     
  Lines         949      913      -36     
  Branches      184      181       -3     
==========================================
- Hits          903      869      -34     
+ Misses         44       42       -2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I tested it and it works as described. There's an issue with the messages file, though.


const messages = defineMessages({
'authz.manage.assign.role.title': {
id: 'libraries.authz.manage.add.member.title',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate id in this file.

Removing the allow public read switch.
Updated assign role button text.
Title and subtitle appears in the same line.
Copy link

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@arbrandes arbrandes merged commit 74ee431 into openedx:master Mar 17, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Task - RBAC AuthZ - Update global header

3 participants