Modifications on the authz title(header) component#99
Modifications on the authz title(header) component#99arbrandes merged 1 commit intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
abe5257 to
305848d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 95.15% 95.18% +0.02%
==========================================
Files 46 45 -1
Lines 949 913 -36
Branches 184 181 -3
==========================================
- Hits 903 869 -34
+ Misses 44 42 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arbrandes
left a comment
There was a problem hiding this comment.
Code looks good. I tested it and it works as described. There's an issue with the messages file, though.
|
|
||
| const messages = defineMessages({ | ||
| 'authz.manage.assign.role.title': { | ||
| id: 'libraries.authz.manage.add.member.title', |
Removing the allow public read switch. Updated assign role button text. Title and subtitle appears in the same line.
305848d to
ed3da72
Compare
Description
Updating app title (header) to match new design.
Removing the allow public read switch. (Moved to studio openedx/frontend-app-authoring#2942)
Updated assign role button text.
Title and subtitle appears in the same line.
Resolves #94
On team members table:

On specific user view:

Testing instructions
Case 1:
Case 1: