Skip to content

Conversation

@BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Apr 3, 2025

Description

This PR modifies the connection between Teams with Content Groups to enable only if Teams is enabled.

Currently, when a Course Author decides to disable Teams, the configured restrictions remain on the units and it’s possible to remove/add restrictions. However, as Teams is disabled, the tab in the LMS doesn’t appear, Learners cannot join/leave any teams, and Course Authors cannot manage them either.

For now on, if the Course Author decides to disable Teams all restrictions applied in the units are disabled and the Course Author can't edit them. If the Course Author decides to re-enable Teams the restrictions applied to the units are enabled and the Course Author can edit them.

Supporting information

Testing instructions

  1. Create a Tutor environment.

  2. Create a mount of edx-platform with the changes in this branch PR.

  3. Create a course waffle flag in {lms_domain}/admin/waffle_utils/waffleflagcourseoverridemodel/

    • Waffle Flag: teams.content_groups_for_teams
    • Course id: [Your Course ID]
    • Enabled: ✅
  4. Enables Teams in the platform creating a teams.enable_teams_app waffle flag in {lms_domain}/admin/waffle/flag/

  5. Activates Teams in your course in Studio > [Your Course] > Content > Pages & Resources > Teams ⚙️ > ◉ Teams Toggle.

  6. Create a few team sets (or groups) from the Course Authoring MFE for your course.

  7. Then, go to the LMS > [Your Course] > Teams and create a few teams within those team sets (or groups/topics)

  8. As a Student, try loading the sections of the course, you'll be able to load each course section. You'll be able to see them as usual.

  9. Now, restrict units for each team as you would with cohorts or enrollment tracks. Studio > Outline > Unit > Configure > Restric access to

  10. As a Student, try loading the units again. You won't be able to see any content.

  11. As Course Author disable Teams in your course similar to step 5.

  12. The Course Author cannot edit unit restrictions by teams, only per cohort and course enrollments.

  13. As a Student, you will be able to see the content of the units restricted by teams without any problem.

Deadline

None

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 3, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 3, 2025

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 3, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 7, 2025
@BryanttV BryanttV force-pushed the bav/teams-with-content-groups-teams-enabled branch 2 times, most recently from 8dffb06 to 1eb1cdd Compare April 10, 2025 20:52
@BryanttV BryanttV force-pushed the bav/teams-with-content-groups-teams-enabled branch 6 times, most recently from 10f5bf2 to 06e240f Compare July 30, 2025 21:51
@BryanttV BryanttV requested a review from mariajgrimaldi July 30, 2025 22:22
@BryanttV
Copy link
Contributor Author

Hi @mariajgrimaldi, could you check this PR, please?

@mphilbrick211
Copy link

@BryanttV @mariajgrimaldi hi there! Is this pull request still in progress?

@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Sep 12, 2025
@mphilbrick211 mphilbrick211 added inactive PR author has been unresponsive for several months and removed core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Sep 12, 2025
@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Sep 12, 2025
@mphilbrick211
Copy link

@BryanttV @mariajgrimaldi hi there! Is this pull request still in progress?

Gentle ping on this @BryanttV @mariajgrimaldi

@BryanttV BryanttV force-pushed the bav/teams-with-content-groups-teams-enabled branch from 06e240f to ea92a2c Compare September 30, 2025 01:22
@mphilbrick211
Copy link

@BryanttV if this is still something you're working on, would you mind moving it to a draft? Or can we close it for now?

@mphilbrick211
Copy link

@BryanttV @mariajgrimaldi hi there! Is this still in progress?

@BryanttV BryanttV force-pushed the bav/teams-with-content-groups-teams-enabled branch 2 times, most recently from 2f11eb8 to b299fcc Compare November 28, 2025 18:58
@BryanttV BryanttV marked this pull request as draft November 28, 2025 19:49
@mphilbrick211
Copy link

Friendly ping on this, @BryanttV

@mphilbrick211
Copy link

Hi @BryanttV @mariajgrimaldi! This has been stalled for a bit. Ok to close?

@BryanttV BryanttV force-pushed the bav/teams-with-content-groups-teams-enabled branch from b299fcc to 2309cd0 Compare February 4, 2026 15:08
@BryanttV
Copy link
Contributor Author

BryanttV commented Feb 4, 2026

Hi @mphilbrick211, this PR is ready for review. Sorry for the delay. @mariajgrimaldi, could you please take a look?

@BryanttV BryanttV marked this pull request as ready for review February 4, 2026 17:35
@BryanttV BryanttV force-pushed the bav/teams-with-content-groups-teams-enabled branch from 2309cd0 to 2a395f6 Compare February 4, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). inactive PR author has been unresponsive for several months open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

3 participants