-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: enable teams with content groups connection only if teams is enabled #36475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: enable teams with content groups connection only if teams is enabled #36475
Conversation
|
Thanks for the pull request, @BryanttV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
8dffb06 to
1eb1cdd
Compare
10f5bf2 to
06e240f
Compare
|
Hi @mariajgrimaldi, could you check this PR, please? |
|
@BryanttV @mariajgrimaldi hi there! Is this pull request still in progress? |
Gentle ping on this @BryanttV @mariajgrimaldi |
06e240f to
ea92a2c
Compare
|
@BryanttV if this is still something you're working on, would you mind moving it to a draft? Or can we close it for now? |
|
@BryanttV @mariajgrimaldi hi there! Is this still in progress? |
2f11eb8 to
b299fcc
Compare
|
Friendly ping on this, @BryanttV |
|
Hi @BryanttV @mariajgrimaldi! This has been stalled for a bit. Ok to close? |
…am partition scheme
b299fcc to
2309cd0
Compare
|
Hi @mphilbrick211, this PR is ready for review. Sorry for the delay. @mariajgrimaldi, could you please take a look? |
2309cd0 to
2a395f6
Compare
Description
This PR modifies the connection between Teams with Content Groups to enable only if Teams is enabled.
Currently, when a Course Author decides to disable Teams, the configured restrictions remain on the units and it’s possible to remove/add restrictions. However, as Teams is disabled, the tab in the LMS doesn’t appear, Learners cannot join/leave any teams, and Course Authors cannot manage them either.
For now on, if the Course Author decides to disable Teams all restrictions applied in the units are disabled and the Course Author can't edit them. If the Course Author decides to re-enable Teams the restrictions applied to the units are enabled and the Course Author can edit them.
Supporting information
CONTENT_GROUPS_FOR_TEAMSWaffle FlagTesting instructions
Create a Tutor environment.
Create a mount of edx-platform with the changes in this branch PR.
Create a course waffle flag in
{lms_domain}/admin/waffle_utils/waffleflagcourseoverridemodel/teams.content_groups_for_teamsEnables Teams in the platform creating a
teams.enable_teams_appwaffle flag in{lms_domain}/admin/waffle/flag/Activates Teams in your course in Studio > [Your Course] > Content > Pages & Resources > Teams ⚙️ > ◉ Teams Toggle.
Create a few team sets (or groups) from the Course Authoring MFE for your course.
Then, go to the LMS > [Your Course] > Teams and create a few teams within those team sets (or groups/topics)
As a Student, try loading the sections of the course, you'll be able to load each course section. You'll be able to see them as usual.
Now, restrict units for each team as you would with cohorts or enrollment tracks. Studio > Outline > Unit > Configure > Restric access to
As a Student, try loading the units again. You won't be able to see any content.
As Course Author disable Teams in your course similar to step 5.
The Course Author cannot edit unit restrictions by teams, only per cohort and course enrollments.
As a Student, you will be able to see the content of the units restricted by teams without any problem.
Deadline
None