-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: Convert UUIDField columns to uuid type for Mariadb #37966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The behavior of the MariaDB backend has changed behavior for UUIDField from a `CharField(32)` to an actual `uuid` type. This is not converted automatically, which results in all writes to the affected columns to error with a message about the data being too long. This is because the actual string being written is a UUID with the `-` included, resulting in a 36 character value which can't be inserted into a 32 character column.
|
Thanks for the pull request, @Ardiea! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
I will review this, but please merge after #37924 (and rebase on top of it). I'm doing some migration squashing, and I'm worried that these two PRs are going to collide in a confusing way otherwise. Thank you. |
ormsbee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just merged #37924. Please rebase onto the latest master, and remake this migration as migration 0016. Thank you.
Description
The behavior of the MariaDB backend has changed behavior for UUIDField from a
CharField(32)to an actualuuidtype. This is not converted automatically, which results in all writes to the affected columns to error with a message about the data being too long. This is because the actual string being written is a UUID with the-included, resulting in a 36 character value which can't be inserted into a 32 character column.Supporting information
https://docs.djangoproject.com/en/5.2/releases/5.0/#migrating-uuidfield
Testing instructions
Configure edx-platform to use a MariaDB database as well as the work necessary to use Libraries V2 (meilisearch, etc), run the migrations up through the Django 5.2 update, then perform the 5.2 update and try to create a new V2 Library. It will error. After applying these migrations it should work.
Deadline
This is a blocking error that prevents the LibrariesV2 from being operational when using MariaDB as the database engine.
Other information
This is in addition to the migrations found in PR #37494