fix: remove duplicate empty-string alternative in continuation_token regex#249
Conversation
|
|
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughRemoves a redundant empty-string alternative from the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
005118f to
a7ffbd6
Compare
There was a problem hiding this comment.
Pull request overview
This PR cleans up a redundant empty-string alternative in the continuation_token validation regex for ListStoresRequest in the OpenFGA v1 service proto, aligning it with the pattern used by other continuation token fields in the same file.
Changes:
- Remove the duplicated
^$|alternative from thecontinuation_tokenvalidation regex inListStoresRequest. - Standardize the regex to match the existing
^$|^[A-Za-z0-9-_]+={0,2}$pattern used elsewhere.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
a7ffbd6 to
567d71a
Compare
…regex
The ListStoresRequest.continuation_token validation pattern had a
redundant '^$|' prefix, making it '^$|^$|^[A-Za-z0-9-_]+={0,2}$'
instead of '^$|^[A-Za-z0-9-_]+={0,2}$' like all other continuation_token
fields in the file.
567d71a to
b334c7d
Compare
| string continuation_token = 2 [ | ||
| json_name = "continuation_token", | ||
| (validate.rules).string.max_bytes = 5120, | ||
| (validate.rules).string.pattern = "^$|^$|^[A-Za-z0-9-_]+={0,2}$", |
There was a problem hiding this comment.
primary change, rest of the changes are auto-generated code changes
senojj
left a comment
There was a problem hiding this comment.
Change properly addresses the intent.
What
Removes a redundant
^$|in thecontinuation_tokenvalidation pattern forListStoresRequest.Why
The pattern on line 1838 was:
All other
continuation_tokenfields in the file use:The duplicate
^$|is functionally equivalent but inconsistent with the rest of the file.Impact
No behavioral change — the regex matches the same set of strings. This is a consistency fix only.
Closes #245
Summary by CodeRabbit
Release Notes