7903750: TimeBudget (-tb) does not fulfill its promisses by judovana · Pull Request #161 · openjdk/jcstress

judovana · 2025-03-05T15:52:59Z

Added warning, when time budget is to small, and final run will run at least two times longer.

Progress

Change must not contain extraneous whitespace
Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

CODETOOLS-7903750: TimeBudget (-tb) does not fulfill its promisses (Bug - P4)

Reviewers

Galder Zamarreño (@galderz - no project role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/161/head:pull/161
$ git checkout pull/161

Update a local copy of the PR:
$ git checkout pull/161
$ git pull https://git.openjdk.org/jcstress.git pull/161/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 161

View PR using the GUI difftool:
$ git pr show -t 161

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/161.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-03-05T15:53:48Z

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-03-05T15:54:41Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

mlbridge · 2025-03-05T15:57:28Z

Webrevs

judovana · 2025-03-21T13:08:55Z

hi @galderz ! TYVM for eyeball! I had adjusted to all of your comments, and left few question marks. Hope that is ok. thank you again! (If I missed any, it was not intentional)

galderz

Just a small comment

galderz · 2025-03-28T05:22:58Z

All good now, thanks @judovana! @shipilev can you give it a final review?

judovana · 2025-03-28T09:02:19Z

tyvm!

bridgekeeper · 2025-04-25T14:59:40Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-04-25T15:01:34Z

loosing faith

judovana · 2025-04-25T15:42:43Z

Loosing the faith...

judovana · 2025-05-21T12:27:33Z

../live..

bridgekeeper · 2025-06-18T13:34:28Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-06-19T06:46:32Z

Faith restored!

shipilev · 2025-06-19T09:06:40Z

Please pull/rebase to current master :)

Required two small refactorings to get nice code reused

- ms -= TimeUnit.HOURS.toMillis(hours); - ms -= TimeUnit.MINUTES.toMillis(minutes);

The NPE workaround was causing NPE to be only delayed for later

Co-authored-by: Galder Zamarreño <galder@redhat.com>

openjdk · 2025-06-23T08:19:14Z

@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

judovana · 2025-06-23T08:46:59Z

hi! All my PRs rebased.

judovana · 2025-07-16T14:46:16Z

faith restored

bridgekeeper · 2025-08-13T21:14:47Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-08-14T11:02:35Z

Is there hope?

bridgekeeper · 2025-09-12T00:25:04Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-09-12T10:04:56Z

Loosing the faith...

bridgekeeper · 2025-10-10T15:11:31Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2025-11-08T03:50:47Z

@judovana This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

judovana · 2025-11-08T08:13:16Z

/open

openjdk · 2025-11-08T08:14:54Z

@judovana This pull request is now open

judovana · 2025-11-11T08:21:19Z

keep_alive

bridgekeeper · 2025-12-10T13:10:36Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-12-22T17:19:46Z

Need for this still valid

judovana · 2026-01-08T11:57:00Z

keep alive

bridgekeeper · 2026-02-05T20:26:10Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2026-02-06T11:22:31Z

Once upon a midnight dreary, while I pondered, weak and weary,
Over many a quaint and curious volume of forgotten lore—
    While I nodded, nearly napping, suddenly there came a tapping,
As of some one gently rapping, rapping at my chamber door.
“’Tis some visitor,” I muttered, “tapping at my chamber door—
            Only this and nothing more.”

bridgekeeper · 2026-03-06T13:06:42Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2026-03-16T16:18:16Z

      Ah, distinctly I remember it was in the bleak December,
And each separate dying ember wrought its ghost upon the floor.
   Eagerly I wished the morrow;- vainly I had sought to borrow
From my books surcease of sorrow- sorrow for the lost Lenore-
For the rare and radiant maiden whom the angels name Lenore-
                 Nameless here for evermore.

bridgekeeper · 2026-04-13T17:37:34Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

openjdk bot changed the title ~~7903750: TimeBudget (-tb) does not fulfill its promisses~~ 7903750: TimeBudget (-tb) does not fulfill its promisses Mar 5, 2025

openjdk bot added the rfr Pull request is ready for review label Mar 5, 2025

galderz suggested changes Mar 21, 2025

View reviewed changes

galderz suggested changes Mar 24, 2025

View reviewed changes

Comment thread jcstress-core/src/main/java/org/openjdk/jcstress/JCStress.java Outdated

galderz suggested changes Mar 26, 2025

View reviewed changes

Comment thread jcstress-core/src/main/java/org/openjdk/jcstress/JCStress.java Outdated

galderz approved these changes Mar 28, 2025

View reviewed changes

judovana and others added 11 commits June 23, 2025 10:17

intitial -tb warning

3f78d3c

print time budfget also for listing

750e68c

Required two small refactorings to get nice code reused

added warning if timebudget is to small

ce222f8

Replaced System.out by preset out

4bb46b9

renamed getNiceMsTimeDate to formatMsToDaysAndTime

99dab96

Used WARNING: and FATAL: instead of +++ WARNING - and +++ FATAL -

8933dc5

Removed unnecessary shortening of MS before next conversion

d500fef

- ms -= TimeUnit.HOURS.toMillis(hours); - ms -= TimeUnit.MINUTES.toMillis(minutes);

Removed unnecesasary NPE check in getTimeBudget

7deb12a

The NPE workaround was causing NPE to be only delayed for later

Removed table like formatting for time budget warnning

c08e5f3

directly return new instance without intermediate variable

15ecb1a

Co-authored-by: Galder Zamarreño <galder@redhat.com>

Removed duplicated construcion of timebudget

cbedff7

judovana force-pushed the betterTimeBudgetWarning branch from 7b68f54 to cbedff7 Compare June 23, 2025 08:18

bridgekeeper bot closed this Nov 8, 2025

openjdk bot reopened this Nov 8, 2025

Conversation

judovana commented Mar 5, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Mar 5, 2025

Uh oh!

openjdk bot commented Mar 5, 2025

Uh oh!

mlbridge bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

judovana commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

galderz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

galderz commented Mar 28, 2025

Uh oh!

judovana commented Mar 28, 2025

Uh oh!

bridgekeeper bot commented Apr 25, 2025

Uh oh!

judovana commented Apr 25, 2025

Uh oh!

judovana commented Apr 25, 2025

Uh oh!

judovana commented May 21, 2025

Uh oh!

bridgekeeper bot commented Jun 18, 2025

Uh oh!

judovana commented Jun 19, 2025

Uh oh!

shipilev commented Jun 19, 2025

Uh oh!

openjdk bot commented Jun 23, 2025

Uh oh!

judovana commented Jun 23, 2025

Uh oh!

judovana commented Jul 16, 2025

Uh oh!

bridgekeeper bot commented Aug 13, 2025

Uh oh!

judovana commented Aug 14, 2025

Uh oh!

bridgekeeper bot commented Sep 12, 2025

Uh oh!

judovana commented Sep 12, 2025

Uh oh!

bridgekeeper bot commented Oct 10, 2025

Uh oh!

bridgekeeper bot commented Nov 8, 2025

Uh oh!

judovana commented Nov 8, 2025

Uh oh!

openjdk bot commented Nov 8, 2025

Uh oh!

judovana commented Nov 11, 2025

Uh oh!

bridgekeeper bot commented Dec 10, 2025

Uh oh!

judovana commented Dec 22, 2025

Uh oh!

judovana commented Jan 8, 2026

Uh oh!

bridgekeeper bot commented Feb 5, 2026

judovana commented Mar 5, 2025 •

edited by openjdk bot

Loading

mlbridge bot commented Mar 5, 2025 •

edited

Loading

judovana commented Mar 21, 2025 •

edited

Loading