8367583: sun/security/util/AlgorithmConstraints/InvalidCryptoDisabledAlgos.java fails after JDK-8244336#4355
8367583: sun/security/util/AlgorithmConstraints/InvalidCryptoDisabledAlgos.java fails after JDK-8244336#4355satyenme wants to merge 3 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
|
@satyenme This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8367583: sun/security/util/AlgorithmConstraints/InvalidCryptoDisabledAlgos.java fails after JDK-8244336 Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle. Risk: Low. Ran GHA Sanity Checks and adjusted test. Patch is clean. Change has been accepted by Oracle (and test is currently failing). |
|
@satyenme Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
This reverts commit 75b291b.
|
Sorry about that, accidentally pushed commit to this branch - reverted to only include the relevant patch |
|
/integrate |
|
Going to push as commit 35ad4d5. |
Backporting JDK-8367583: sun/security/util/AlgorithmConstraints/InvalidCryptoDisabledAlgos.java fails after JDK-8244336. Fixes buggy test. Ran GHA Sanity Checks and fixed test directly to confirm passing. Patch is clean. Backporting for parity with Oracle.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4355/head:pull/4355$ git checkout pull/4355Update a local copy of the PR:
$ git checkout pull/4355$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4355/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4355View PR using the GUI difftool:
$ git pr show -t 4355Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4355.diff
Using Webrev
Link to Webrev Comment