Skip to content

8367583: sun/security/util/AlgorithmConstraints/InvalidCryptoDisabledAlgos.java fails after JDK-8244336#4355

Closed
satyenme wants to merge 3 commits intoopenjdk:masterfrom
satyenme:8367583
Closed

8367583: sun/security/util/AlgorithmConstraints/InvalidCryptoDisabledAlgos.java fails after JDK-8244336#4355
satyenme wants to merge 3 commits intoopenjdk:masterfrom
satyenme:8367583

Conversation

@satyenme
Copy link
Copy Markdown

@satyenme satyenme commented Apr 6, 2026

Backporting JDK-8367583: sun/security/util/AlgorithmConstraints/InvalidCryptoDisabledAlgos.java fails after JDK-8244336. Fixes buggy test. Ran GHA Sanity Checks and fixed test directly to confirm passing. Patch is clean. Backporting for parity with Oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8367583 needs maintainer approval

Issue

  • JDK-8367583: sun/security/util/AlgorithmConstraints/InvalidCryptoDisabledAlgos.java fails after JDK-8244336 (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4355/head:pull/4355
$ git checkout pull/4355

Update a local copy of the PR:
$ git checkout pull/4355
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4355/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4355

View PR using the GUI difftool:
$ git pr show -t 4355

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4355.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 6, 2026

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367583: sun/security/util/AlgorithmConstraints/InvalidCryptoDisabledAlgos.java fails after JDK-8244336

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ff538c7f5641bb24748243da44de5d964141ae31 8367583: sun/security/util/AlgorithmConstraints/InvalidCryptoDisabledAlgos.java fails after JDK-8244336 Apr 6, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 6, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 6, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 6, 2026

Webrevs

@satyenme
Copy link
Copy Markdown
Author

satyenme commented Apr 6, 2026

/approval request for backport of JDK-8367583: sun/security/util/AlgorithmConstraints/InvalidCryptoDisabledAlgos.java fails after JDK-8244336

Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle.

Risk: Low. Ran GHA Sanity Checks and adjusted test. Patch is clean. Change has been accepted by Oracle (and test is currently failing).

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

@satyenme
8367583: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Apr 6, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

@satyenme Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Apr 6, 2026
@satyenme
Copy link
Copy Markdown
Author

satyenme commented Apr 6, 2026

Sorry about that, accidentally pushed commit to this branch - reverted to only include the relevant patch

@openjdk openjdk bot added clean Identical backport; no merge resolution required ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Apr 6, 2026
@satyenme
Copy link
Copy Markdown
Author

satyenme commented Apr 7, 2026

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 7, 2026

Going to push as commit 35ad4d5.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 7, 2026
@openjdk openjdk bot closed this Apr 7, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 7, 2026

@satyenme Pushed as commit 35ad4d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant