chore: upgrade CI pipeline#38
Merged
Merged
Conversation
- Add concurrency cancellation (same PR/branch cancels old runs) - Add scope detection: docs-only commits skip heavy jobs - Split monolithic job into typecheck → build → test chain - Add release-check job (PR-only, checks version bump / changeset) - Remove duplicate pnpm test from release.yml Closes #36
best
commented
Feb 22, 2026
Contributor
Author
best
left a comment
There was a problem hiding this comment.
🤖 开发经理 AI Review — PR #38 CI Upgrade
Informational only, 不阻断合并。
Checklist
| 项目 | 说明 | |
|---|---|---|
| ✅ | 类型安全 | YAML 配置,无类型问题 |
| ✅ | 错误处理 | scope 检测有 fallback(zero SHA → HEAD~1),稳健 |
| ✅ | 测试覆盖 | 基础设施变更,CI 本身即验证 |
| API 一致性 | test job 从单一 job 拆分为 4 个 — branch protection 的 required status check 名称需同步更新(原 test,现在是 Test (unit + integration)) |
|
| ✅ | 破坏性变更 | 无 breaking change,release.yml 清理合理 |
具体建议
-
Branch protection 需更新:master 的 required status check 目前配置的是
test,CI 拆分后 job name 变为Test (unit + integration),建议在 PR merge 后同步更新 branch protection rule。 -
artifact 路径:
upload-artifact上传packages/*/dist,download-artifact下载到packages,路径层级需确认解压后结构是否正确(应为packages/*/dist/...)。 -
release-check 是占位符:当前只打印不失败,后续可接入 changeset 强校验。
总体评价
结构清晰,分层合理,是一次高质量的 CI 重构。关注 branch protection status check 名称同步即可。
由开发经理巡逻 AI Review · openlinkos/agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36
Changes
typecheck→build→test— each is a separate job; early failure stops the chainpnpm teststep (CI workflow already handles it)