Skip to content

fix: prevent command injection in release-openmfp workflow#238

Merged
nexus49 merged 1 commit intofeat/releasefrom
fix/release-input-injection
Apr 7, 2026
Merged

fix: prevent command injection in release-openmfp workflow#238
nexus49 merged 1 commit intofeat/releasefrom
fix/release-input-injection

Conversation

@nexus49
Copy link
Copy Markdown
Member

@nexus49 nexus49 commented Apr 7, 2026

Summary

  • Fixes command injection vulnerability in release-openmfp.yml where inputs.version was interpolated directly into run: shell scripts
  • Passes the version through an environment variable ($VERSION) instead, so shell metacharacters in the input are not interpreted

Context

Review finding from PR #226${{ inputs.version }} in a run: block allows arbitrary command execution via crafted workflow_dispatch input.

Pass inputs.version through an environment variable instead of
interpolating it directly into the shell script, avoiding injection
via crafted workflow_dispatch input values.

Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com>
On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
@nexus49 nexus49 requested a review from a team as a code owner April 7, 2026 08:52
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 7, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a4dedb68-cf8b-432f-84e8-03188e4453ff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-input-injection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nexus49 nexus49 merged commit 6713105 into feat/release Apr 7, 2026
1 check passed
@nexus49 nexus49 deleted the fix/release-input-injection branch April 7, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants