Skip to content

fix: ensure sequential release execution with failure gating#239

Merged
nexus49 merged 1 commit intofeat/releasefrom
fix/release-sequential-execution
Apr 7, 2026
Merged

fix: ensure sequential release execution with failure gating#239
nexus49 merged 1 commit intofeat/releasefrom
fix/release-sequential-execution

Conversation

@nexus49
Copy link
Copy Markdown
Member

@nexus49 nexus49 commented Apr 7, 2026

Summary

  • gh workflow run is fire-and-forget — it returns immediately without waiting for the triggered run
  • This change records a timestamp before triggering, polls for the newly created run ID, then uses gh run watch --exit-status to block until completion
  • If portal-ui-lib release fails, portal-server-lib is never triggered

Context

Review finding #3 from PR #226 — the PR description claimed sequential execution with failure gating, but both repos were triggered in parallel with no waiting.

gh workflow run is fire-and-forget. Record a timestamp before
triggering, poll for the new run ID, then use gh run watch
--exit-status to block until completion. If portal-ui-lib fails,
portal-server-lib is never triggered.

Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com>
On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
@nexus49 nexus49 requested a review from a team as a code owner April 7, 2026 08:58
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 7, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 00d6f828-a24a-4920-8688-4ed4de0f06e5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-sequential-execution

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nexus49 nexus49 merged commit c37dc56 into feat/release Apr 7, 2026
1 check passed
@nexus49 nexus49 deleted the fix/release-sequential-execution branch April 7, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants