poc: SWITCH relay implementation (moq-transport PR #1378)#287
Draft
gwendalsimon wants to merge 3 commits intoopenmoq:mainfrom
Draft
poc: SWITCH relay implementation (moq-transport PR #1378)#287gwendalsimon wants to merge 3 commits intoopenmoq:mainfrom
gwendalsimon wants to merge 3 commits intoopenmoq:mainfrom
Conversation
* Add MoqxSession: thin MoQRelaySession subclass that dispatches onSwitch() to MoqxRelay and exposes publishForSwitch() + writeCatchupToHandle() — both require protected MoQSession access * Wire MoqxRelayServer::createSession() to produce MoqxSession instances and call setRelay() immediately after construction * Add SwitchTypes.h: SwitchTransition struct + kSwitchTransitionParamKey * Add GroupStartObserver.h: lightweight TrackConsumer that fires a callback on each beginSubgroup() for G_switch detection * Add SwitchHandler: full relay-side state machine (VALIDATE → SUBSCRIBE_TARGET → OBSERVE_GSWITCH → CUT_OLD → CATCHUP+LIVE) including pre-population of availableTarget from forwarder.largest(), inline FETCH catch-up via writeCatchupToHandle(), and Phase 2 drain loop * Add MoqxRelay::handleSwitch(), getForwarder(), getOrSubscribeForwarder(), getSubscriptionHandle(), cache() to complete the relay glue * Add moqx_switch_handler_test placeholder target to test/CMakeLists.txt * Build not yet verified — requires cmake 3.25+ and system deps: run: sudo deps/moxygen/standalone/install-system-deps.sh Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
The moxygen changes are now browsable at: https://github.com/gwendalsimon/moxygen/tree/feat/switch-poc The moqx implementation is self-contained in this branch. The moxygen submodule carries local-only changes that would need to land in moxygen before this can be merged. Here is what those changes are:
|
Picks up fix(switch): assign SWITCH = 0x1F per moq-transport PR #1378 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is