MoqxCache: cap publisher cache duration, skip caching when mcd=0#302
Open
MoqxCache: cap publisher cache duration, skip caching when mcd=0#302
Conversation
Adds setMaxAllowedCacheDuration() so operators can cap publisher-set cache durations. setTrackExtensions() now extracts the publisher's max cache duration extension, clamps it to the cap, and falls back to defaultMaxCacheDuration_ when the publisher doesn't set one. setMaxCacheDuration/clearMaxCacheDuration are now private; callers should go through setTrackExtensions. Adds CacheTrack::shouldSkipCaching() which returns true when evicted or when maxCacheDuration is explicitly 0ms. defaultMaxCacheDuration=0ms acts as "opt-in only" mode: publisher must set a non-zero duration or objects are forwarded without being written to cache. Wires cache.maxCacheDuration from CacheConfig into the new setMaxAllowedCacheDuration() call in MoqxRelay, removing the TODO. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
afrind
requested review from
Oxyd,
TimEvens,
akash-a-n,
gmarzot,
michalhosna,
mondain,
peterchave and
suhasHere
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds setMaxAllowedCacheDuration() so operators can cap publisher-set cache durations. setTrackExtensions() now extracts the publisher's max cache duration extension, clamps it to the cap, and falls back to defaultMaxCacheDuration_ when the publisher doesn't set one. setMaxCacheDuration/clearMaxCacheDuration are now private; callers should go through setTrackExtensions.
Adds CacheTrack::shouldSkipCaching() which returns true when evicted or when maxCacheDuration is explicitly 0ms. defaultMaxCacheDuration=0ms acts as "opt-in only" mode: publisher must set a non-zero duration or objects are forwarded without being written to cache.
Wires cache.maxCacheDuration from CacheConfig into the new setMaxAllowedCacheDuration() call in MoqxRelay, removing the TODO.
This change is