CCLA-1008: [SDK] align python SDK with the DB cleaup some table#133
Merged
UBiqube-ydu merged 5 commits intomasterfrom Jul 22, 2025
Merged
CCLA-1008: [SDK] align python SDK with the DB cleaup some table#133UBiqube-ydu merged 5 commits intomasterfrom
UBiqube-ydu merged 5 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the Python SDK with database cleanup by commenting out assertions related to the mail_alerting field in device tests, likely due to the removal of this field from the database schema.
- Commented out
mail_alertingfield assertions in device test cases - Updated two test methods to remove validation of the deprecated field
Comments suppressed due to low confidence (2)
tests/test_device_get.py:41
- Instead of commenting out this assertion, consider removing it entirely if the mail_alerting field has been removed from the database schema. Commented-out test code reduces maintainability and clarity.
# assert not device.mail_alerting
tests/test_device_get.py:101
- Instead of commenting out this assertion, consider removing it entirely if the mail_alerting field has been removed from the database schema. Commented-out test code reduces maintainability and clarity.
# assert not device.mail_alerting
UBiqube-ydu
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.