Skip to content

OPSLAB-69: MS stack management methods (create a stack, apply a stack)#139

Merged
UBiqube-ydu merged 31 commits intoopenmsa:masterfrom
sdi38:master
Aug 6, 2025
Merged

OPSLAB-69: MS stack management methods (create a stack, apply a stack)#139
UBiqube-ydu merged 31 commits intoopenmsa:masterfrom
sdi38:master

Conversation

@sdi38
Copy link
Copy Markdown
Contributor

@sdi38 sdi38 commented Aug 5, 2025

No description provided.

sdi38 and others added 24 commits August 1, 2025 09:49
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment thread msa_sdk/order.py Outdated

self._call_post(params, timeout)


Copy link
Copy Markdown
Contributor

@UBiqube-ydu UBiqube-ydu Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless blank line

Comment thread msa_sdk/order.py Outdated
self._call_post(params, timeout)


def command_stack(self, command: str, params,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method should be removed.

Comment thread msa_sdk/order_stack.py Outdated
@@ -0,0 +1,76 @@
"""Module Order."""
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not Order!

Comment thread msa_sdk/order_stack.py Outdated

def apply_command_stacked(self, timeout=300) -> None:
"""
Apply all commands stack of a device.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stack --> stacked

Comment thread msa_sdk/order_stack.py Outdated
-------
None
"""
self.action = 'Apply all commands stack of a device'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stack --> stacked

Copy link
Copy Markdown
Contributor

@UBiqube-ydu UBiqube-ydu Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one blank line removed in this file. This file should not be part of the PR.

Comment thread tests/test_order_stack.py Outdated
@@ -0,0 +1,42 @@
"""
Test Order Command
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order Stack instead of Order Command

Comment thread msa_sdk/order_stack.py Outdated
timeout=300) -> None:
"""

To queue multiple commands in a stack.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

push is more suitable than queue.

@Vignaudo
Copy link
Copy Markdown
Contributor

Vignaudo commented Aug 5, 2025

Cool 👍

@UBiqube-ydu UBiqube-ydu merged commit ce1f0b9 into openmsa:master Aug 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants