Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the profile existence check from a POST-based API call to a GET-based one, updating both the implementation and its corresponding test. The change aligns with RESTful principles where GET requests should be used for read-only operations.
Key changes:
- Changed the
exist()method inProfileclass from using POST (_call_post()) to GET (_call_get()) - Updated the API endpoint from
/profile/v1/exist/{reference}to/profile/ref?extRef={reference} - Modified the return logic to check HTTP status code (200) instead of parsing JSON response
- Added type hints to
MSA_APIclass attributes and methods for better type safety - Added null-safety check in
check_response()method to prevent potential AttributeError
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/test_profie.py | Updated test to mock _call_get instead of _call_post and verify the new API endpoint format |
| msa_sdk/profile.py | Refactored exist() method to use GET request and check status code instead of parsing JSON response |
| msa_sdk/msa_api.py | Added type annotations for better type safety and added null-check in check_response() to handle None responses |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
UBiqube-ydu
approved these changes
Dec 23, 2025
013b4bc to
9da2bf5
Compare
UBiqube-ydu
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.