Skip to content

Fix CI workflow to run modern and legacy tests with proper isolation #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix CI workflow to run modern and legacy tests with proper isolation #1102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9539920
Initial plan
Copilot Jan 7, 2026
cb9a7f0
Fix CI workflow to run both modern and legacy tests with proper isola…
Copilot Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .github/workflows/maven-project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,24 @@ jobs:
- name: Build project
run: docker exec openo-tomcat-dev .devcontainer/development/scripts/make install

- name: Run unit tests & build JSP files
run: docker exec openo-tomcat-dev mvn package -Pjspc,modern-tests -Ddependency.lock.filename=dependencies-lock-modern.json
# Run tests in isolation matching the make script behavior
# Phase 1: Modern tests with JUnit 5 profile
- name: Build for modern tests
run: docker exec openo-tomcat-dev mvn clean -DskipModernTests=true -DskipLegacyTests=true -T 1C package war:exploded -Pjspc,modern-tests -Ddependency.lock.filename=dependencies-lock-modern.json

- name: Run modern tests
run: docker exec openo-tomcat-dev mvn test -Pmodern-tests -DskipLegacyTests=true -Ddependency.lock.filename=dependencies-lock-modern.json

# Clean up between test phases to ensure complete isolation
- name: Clean up between test phases
run: docker exec openo-tomcat-dev mvn clean -q

# Phase 2: Legacy tests without JUnit 5 profile
- name: Build for legacy tests
run: docker exec openo-tomcat-dev mvn clean -DskipModernTests=true -DskipLegacyTests=true -T 1C package war:exploded -Pjspc

- name: Run legacy tests
run: docker exec openo-tomcat-dev mvn test -DskipModernTests=true

lint:
runs-on: ubuntu-latest
Expand Down
Loading