Dogfish pom cleanup

[yingbull]

Summary by Sourcery

Clean up project configuration by removing outdated dependencies and code, upgrading build plugins, adjusting test scopes, and adding required libraries

Enhancements:

• Bump maven-compiler-plugin, maven-war-plugin, maven-checkstyle-plugin, checkstyle and build-helper-maven-plugin to current versions
• Limit Selenium and WebDriverManager dependencies to test scope
• Add Apache Commons Exec dependency for ExternalEDocConverter

Chores:

• Remove obsolete local_repo and OCAN-related dependencies from pom.xml
• Clean up OCAN warning code and remove OCAN fields and links in JSP pages
• Delete unused OscarPingTalk.java class and remove resource filtering exclusions

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR streamlines project configuration by removing obsolete dependencies and resource exclusions from the POM, adding and scoping necessary dependencies, bumping plugin versions, and cleans up legacy UI code along with deleting an unused Java class.

Class diagram for removed OscarPingTalk class

classDiagram
    class OscarPingTalk {
        <<removed>>
    }

Loading

File-Level Changes

Change	Details	Files
POM cleanup: removed obsolete dependencies and resource excludes	Removed multiple custom local_repo dependencies (hsfo, hsfo2, ocan, chip/ping group, cbi_ws_client) Removed unused resource exclusion	pom.xml
POM update: added new dependencies and scopes	Added Apache Commons Exec dependency Scoped Selenium and WebDriverManager to test	pom.xml
POM update: bumped plugin versions	Updated maven-compiler-plugin, maven-war-plugin, maven-checkstyle-plugin Updated Checkstyle engine and build-helper-maven-plugin versions	pom.xml
Removed legacy UI code from JSP/JS	Dropped OCAN warning logic from schedulePage.js.jsp Removed OCAN-related fields from ViewFacility.jsp and admin.jsp	src/main/webapp/provider/schedulePage.js.jsp src/main/webapp/PMmodule/Admin/Facility/ViewFacility.jsp src/main/webapp/admin/admin.jsp
Deleted obsolete Java class	Removed OscarPingTalk.java	src/main/java/oscar/OscarPingTalk.java

Possibly linked issues

• Added DownloadInIterceptor import to the classes #1: PR removes various unused dependencies and updates Maven plugin versions in pom.xml, directly addressing the issue's cleanup and upgrade objectives.
• Fixed the vulnerabilty #123: The PR removes numerous unused dependencies from pom.xml and associated code, directly fulfilling the issue's objective to clean up dependencies.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[Copilot]

Pull Request Overview

This PR removes outdated and unused dependencies and functionality related to OCAN (Ontario Common Assessment of Need) reporting, HSFO, and PING/CHIP communication systems. The cleanup also includes Maven plugin version updates and proper test scoping for Selenium dependencies.

• Removal of OCAN-related dependencies, UI elements, and Java code
• Elimination of HSFO, PING/CHIP libraries and associated functionality
• Maven plugin version updates and dependency scope corrections

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pom.xml	Removes unused dependencies (OCAN, HSFO, PING/CHIP, CBI) and updates Maven plugin versions
dependencies-lock.json	Updates dependency lock file to reflect removed dependencies and scope changes
src/main/webapp/provider/schedulePage.js.jsp	Removes OCAN warning window functionality
src/main/webapp/admin/admin.jsp	Removes OCAN reporting menu links from admin interface
src/main/webapp/PMmodule/Admin/Facility/ViewFacility.jsp	Removes OCAN Service Org Number field from facility view
src/main/java/oscar/OscarPingTalk.java	Complete removal of PING communication client implementation

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.}

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Validate that removing OCAN dependencies and JSP code hasn't inadvertently broken any page rendering or related dynamic behavior.
• Ensure Selenium and WebDriverManager tests still execute properly now that they're scoped to test in the POM.
• After bumping Maven plugin versions, verify there are no new warnings or configuration changes required for a successful clean build.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- Validate that removing OCAN dependencies and JSP code hasn't inadvertently broken any page rendering or related dynamic behavior.
- Ensure Selenium and WebDriverManager tests still execute properly now that they're scoped to test in the POM.
- After bumping Maven plugin versions, verify there are no new warnings or configuration changes required for a successful clean build.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}