Skip to content

Report list 500 and 404 errors#633

Merged
yingbull merged 1 commit into
develop/dogfishfrom
630-report-list-errors
Sep 24, 2025
Merged

Report list 500 and 404 errors#633
yingbull merged 1 commit into
develop/dogfishfrom
630-report-list-errors

Conversation

@LiamStanziani

@LiamStanziani LiamStanziani commented Sep 24, 2025

Copy link
Copy Markdown
Collaborator

Fixed report list 500 and 404 errors that could be found under 3, Day Sheets: "All Appointments" and "Print Day Sheet for only new appointments" as well as 5, "Bad Appt Sheet.

SQL errors fixed by correcting the incorrect db table name of "providers" to be changed to "provider"

Summary by Sourcery

Correct table references in report SQL queries to resolve Day Sheet and Appointment Sheet 500 and 404 errors

Bug Fixes:

  • Fix SQL queries in reportdaysheet.jsp to use table 'provider' instead of 'providers'
  • Fix SQL queries in reportapptsheet.jsp to use table 'provider' instead of 'providers'

@LiamStanziani LiamStanziani self-assigned this Sep 24, 2025
@LiamStanziani LiamStanziani linked an issue Sep 24, 2025 that may be closed by this pull request
2 tasks
@sourcery-ai

sourcery-ai Bot commented Sep 24, 2025

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaced incorrect ‘providers’ table references with ‘provider’ in SQL queries across reportdaysheet.jsp and reportapptsheet.jsp to align with the actual schema and prevent 500/404 errors.

File-Level Changes

Change Details Files
Corrected table name in day sheet report SQL queries
  • Updated from (appointment a, providers p) to (appointment a, provider p)
  • Updated left joins from providers p2 to provider p2
src/main/webapp/report/reportdaysheet.jsp
Corrected table name in appointment sheet report SQL queries
  • Updated from appointment a, providers p to appointment a, provider p
  • Adjusted JOIN condition reference accordingly
src/main/webapp/report/reportapptsheet.jsp

Possibly linked issues

  • #0: PR corrects SQL table name 'providers' to 'provider' resolving report generation errors for Day Sheets and Bad Appt Sheet.
  • Fixed the vulnerabilty #123: The PR corrects SQL table names in report queries, which likely resolves the 500 error in the reports tab.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA ff92a30.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@LiamStanziani LiamStanziani marked this pull request as ready for review September 24, 2025 17:32

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@yingbull yingbull merged commit 3cfca1b into develop/dogfish Sep 24, 2025
13 of 15 checks passed
@yingbull yingbull deleted the 630-report-list-errors branch January 8, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Clicking certain lists under Report List results in Error Code 500

2 participants