Add Method SCOT to Multi-modal data Integration Task#298
Merged
Conversation
LuckyMD
approved these changes
Mar 31, 2021
LuckyMD
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Matches the API and is fully metadata annotated.
…Problems into method-scot-atong
Contributor
Author
|
I broke some strings into multiline strings and added a |
LuckyMD
approved these changes
Mar 31, 2021
Collaborator
|
let's wait for tests and then merge. |
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
==========================================
- Coverage 91.67% 89.23% -2.44%
==========================================
Files 70 71 +1
Lines 1465 1505 +40
Branches 89 89
==========================================
Hits 1343 1343
- Misses 94 134 +40
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lazappi
added a commit
to lazappi/openproblems
that referenced
this pull request
Apr 16, 2021
* master: fix region fix nf wkdir use env.BRANCH rm echo BRANCH -> WKDIR for s3 set branch variable in S3 setup job Fix s3 bucket clash Dimred methods preprocessing (openproblems-bio#301) Add trustworthiness score for dimred task (openproblems-bio#258) Add Method SCOT to Multi-modal data Integration Task (openproblems-bio#298) Update README.md Update README.md Update README.md
lazappi
added a commit
to lazappi/openproblems
that referenced
this pull request
Apr 16, 2021
* master: fix region fix nf wkdir use env.BRANCH rm echo BRANCH -> WKDIR for s3 set branch variable in S3 setup job Fix s3 bucket clash Dimred methods preprocessing (openproblems-bio#301) Add trustworthiness score for dimred task (openproblems-bio#258) Add Method SCOT to Multi-modal data Integration Task (openproblems-bio#298) Update README.md Update README.md Update README.md
lazappi
added a commit
to lazappi/openproblems
that referenced
this pull request
Apr 16, 2021
* master: fix region fix nf wkdir use env.BRANCH rm echo BRANCH -> WKDIR for s3 set branch variable in S3 setup job Fix s3 bucket clash Dimred methods preprocessing (openproblems-bio#301) Add trustworthiness score for dimred task (openproblems-bio#258) Add Method SCOT to Multi-modal data Integration Task (openproblems-bio#298) Update README.md Update README.md Update README.md
lazappi
added a commit
to lazappi/openproblems
that referenced
this pull request
May 12, 2021
…ction * dimred-methods: (34 commits) Update alra.py (openproblems-bio#304) updated template for PR with PR evaluation checks (openproblems-bio#314) pre-commit Fix preprocessing Fix preprocessing Add new preprocessing Add new preprocessing fix region fix nf wkdir use env.BRANCH rm echo BRANCH -> WKDIR for s3 set branch variable in S3 setup job Fix s3 bucket clash Dimred methods preprocessing (openproblems-bio#301) Add trustworthiness score for dimred task (openproblems-bio#258) Add Method SCOT to Multi-modal data Integration Task (openproblems-bio#298) Change batch size to 1k cells for aff. matrix Add preprocessing Fix some small bugs ...
rcannood
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Add nf-tower cli for dataset loader * add mising directive labels for dataset loader * add missing directive labels process datasets * remove space in file name
rcannood
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Add nf-tower cli for dataset loader * add mising directive labels for dataset loader * add missing directive labels process datasets * remove space in file name Former-commit-id: 6ed72c7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Single-cell Optimal Transport method to the multimodal integration task.
Some potential questions:
flake8test, this is useful for documenting where these parameters came from.balancedoption, which is quite important (as it represents separate but important variants of the Gromov-Wasserstein distance).SCOTvia my forked repository. I have submitted a PR on the SCOT GitHub, if this is merged up there it should be a quick fix. Not sure how we want to support these not quite fully packaged methods in the future.Submission type
Testing
Submission guidelines