get_magic_quotes has been removed from PHP, as can be seen here:#76
Open
vsessink wants to merge 1 commit into
Open
get_magic_quotes has been removed from PHP, as can be seen here:#76vsessink wants to merge 1 commit into
vsessink wants to merge 1 commit into
Conversation
https://www.php.net/manual/en/function.get-magic-quotes-gpc.php But the configuration setting it should report on, has been removed even earlier: in PHP 5.4.0: https://www.php.net/releases/5_4_0.php So this check serves no purpose - it has been returning "false" for 10 years.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check has been removed: https://www.php.net/manual/en/function.get-magic-quotes-gpc.php and for good reason: the configuration setting it should report on, has been removed even earlier: in PHP 5.4.0: https://www.php.net/releases/5_4_0.php or about 10 years ago.
So this check serves no purpose - it has been returning
falsefor 10 years.Closes #71