Red Hat Konflux kflux-prd-rh02 update hyperfleet-adapter#114
Red Hat Konflux kflux-prd-rh02 update hyperfleet-adapter#114red-hat-konflux-kflux-prd-rh02[bot] wants to merge 2 commits into
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <konflux@no-reply.konflux-ci.dev>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR. I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThis pull request adds two Tekton PipelineRun manifests to automate container image builds and security scanning for the hyperfleet-adapter. The push-triggered pipeline ( Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/ok-to-test |
Convert the Konflux pull-request pipeline to a tag pipeline that triggers on RC and release version tags. Prow owns PR validation, so the pull-request pipeline is not needed. - Rename pull-request.yaml to tag.yaml - CEL expression matches v* tags (RC and release) - Add extract-version task to strip refs/tags/v prefix - Inject VERSION build-arg into container build - Remove image expiry (tag images persist) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.tekton/hyperfleet-adapter-tag.yaml:
- Line 159: Replace the floating tag in the inline Tekton task image declaration
(the line starting with "image: registry.access.redhat.com/ubi9-minimal:latest")
with a pinned digest reference
(registry.access.redhat.com/ubi9-minimal@sha256:<digest>) so builds are
reproducible; obtain the current sha256 digest (e.g. via skopeo inspect
docker://registry.access.redhat.com/ubi9-minimal:latest | jq -r '.Digest') and
update the image value accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 937f157a-b030-4443-bd94-9d41cd3efde4
📒 Files selected for processing (1)
.tekton/hyperfleet-adapter-tag.yaml
| description: Semantic version extracted from git tag ref | ||
| steps: | ||
| - name: extract | ||
| image: registry.access.redhat.com/ubi9-minimal:latest |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial | 💤 Low value
Consider pinning the base image for reproducibility.
Using :latest tag can lead to non-reproducible builds if the base image changes. Since all external task bundles in this pipeline use pinned sha256 digests, consider pinning this inline task image as well for consistency.
♻️ Suggested pin example
- image: registry.access.redhat.com/ubi9-minimal:latest
+ image: registry.access.redhat.com/ubi9-minimal:9.4@sha256:<digest>You can find the current digest with:
skopeo inspect docker://registry.access.redhat.com/ubi9-minimal:latest | jq -r '.Digest'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.tekton/hyperfleet-adapter-tag.yaml at line 159, Replace the floating tag in
the inline Tekton task image declaration (the line starting with "image:
registry.access.redhat.com/ubi9-minimal:latest") with a pinned digest reference
(registry.access.redhat.com/ubi9-minimal@sha256:<digest>) so builds are
reproducible; obtain the current sha256 digest (e.g. via skopeo inspect
docker://registry.access.redhat.com/ubi9-minimal:latest | jq -r '.Digest') and
update the image value accordingly.
|
/ok-to-test |
Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content
/ok-to-testFor more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization
Please follow the block sequence indentation style introduced by the proprosed PipelineRuns YAMLs, or keep using consistent indentation level through your customized PipelineRuns. When different levels are mixed, it will be changed to the proposed style.