Update google.golang.org/genproto digest to 3700d41#117
Update google.golang.org/genproto digest to 3700d41#117red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
ℹ️ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR. I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughThe pull request updates multiple indirect dependency versions in Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Around line 42-46: The PR unintentionally updates many indirect modules (e.g.,
cloud.google.com/go/auth, cloud.google.com/go/auth/oauth2adapt,
cloud.google.com/go/compute/metadata, cloud.google.com/go/iam,
cloud.google.com/go/pubsub/v2, google.golang.org/genproto etc.); narrow the
change to only the targeted genproto digest by reverting unrelated indirect
version bumps in go.mod, run go mod tidy to regenerate go.sum, and ensure tests
pass; if you need to update those other modules, move them into a separate PR
with its own changelog and test run to limit scope and regression blast radius.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 6887766c-2653-4169-82fb-5f020f024f00
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| cloud.google.com/go/auth v0.18.2 // indirect | ||
| cloud.google.com/go/auth/oauth2adapt v0.2.8 // indirect | ||
| cloud.google.com/go/compute/metadata v0.9.0 // indirect | ||
| cloud.google.com/go/iam v1.5.3 // indirect | ||
| cloud.google.com/go/pubsub/v2 v2.4.0 // indirect | ||
| cloud.google.com/go/iam v1.11.0 // indirect | ||
| cloud.google.com/go/pubsub/v2 v2.5.1 // indirect |
There was a problem hiding this comment.
Scope drift: this PR updates far more than the stated genproto digest.
Lines 42–46, 93–94, and 161–169 show broad indirect upgrades (auth/iam/pubsub/gax/oauth2/api/time), not just google.golang.org/genproto. Please keep this PR to the targeted digest bump or split non-target upgrades into a separate PR to reduce regression/debug blast radius.
Suggested minimal-scope approach
- cloud.google.com/go/auth v0.18.2 // indirect
- cloud.google.com/go/iam v1.11.0 // indirect
- cloud.google.com/go/pubsub/v2 v2.5.1 // indirect
- github.com/googleapis/enterprise-certificate-proxy v0.3.14 // indirect
- github.com/googleapis/gax-go/v2 v2.21.0 // indirect
- golang.org/x/oauth2 v0.36.0 // indirect
- golang.org/x/time v0.15.0 // indirect
- google.golang.org/api v0.274.0 // indirect
+ ... keep existing versions unless required by genproto resolution ...
google.golang.org/genproto v0.0.0-20260511170946-3700d4141b60 // indirectAs per coding guidelines "**: Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity. Validate changes against HyperFleet architecture standards from the linked architecture repository."
Also applies to: 93-94, 161-169
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` around lines 42 - 46, The PR unintentionally updates many indirect
modules (e.g., cloud.google.com/go/auth, cloud.google.com/go/auth/oauth2adapt,
cloud.google.com/go/compute/metadata, cloud.google.com/go/iam,
cloud.google.com/go/pubsub/v2, google.golang.org/genproto etc.); narrow the
change to only the targeted genproto digest by reverting unrelated indirect
version bumps in go.mod, run go mod tidy to regenerate go.sum, and ensure tests
pass; if you need to update those other modules, move them into a separate PR
with its own changelog and test run to limit scope and regression blast radius.
|
Closing: superseded by renovate.json config in #140 (HYPERFLEET-1095). MintMaker will re-create grouped updates on the next Monday cycle. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for the If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
4cfbd41→3700d41Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.