Skip to content

HYPERFLEET-1094 - ci: add /licenses to container image#139

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1094-add-licenses
May 15, 2026
Merged

HYPERFLEET-1094 - ci: add /licenses to container image#139
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1094-add-licenses

Conversation

@ciaranRoche
Copy link
Copy Markdown
Contributor

Summary

  • Copies LICENSE into /licenses/ in the container image for Konflux preflight HasLicense certification check

Test plan

  • Konflux preflight HasLicense check passes
  • No regression in other preflight checks

🤖 Generated with Claude Code

@openshift-ci openshift-ci Bot requested review from mbrudnoy and tirthct May 15, 2026 11:05
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: aa78a754-e8c2-4a73-8003-39ceea8ca283

📥 Commits

Reviewing files that changed from the base of the PR and between b8dcffb and 27c2f55.

📒 Files selected for processing (2)
  • .dockerignore
  • Dockerfile

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Include the project's license file in the runtime container image so it’s available at runtime.
    • Stop excluding the license from build context and update ignore-file comment wording for clarity.

Walkthrough

The Dockerfile runtime stage now includes a COPY --from=builder instruction that copies the LICENSE file from the builder stage to /licenses/LICENSE in the final container image, and .dockerignore no longer excludes LICENSE so the file is available in the build context.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: copying the LICENSE file into /licenses/ directory in the container image for compliance with Konflux certification.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of adding /licenses/ to the container image for the Konflux HasLicense check.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch HYPERFLEET-1094-add-licenses

Warning

Review ran into problems

🔥 Problems

Linked repositories: Couldn't analyze openshift-hyperfleet/architecture - clone failed: Clone operation failed: Cloning into '/home/jailuser/git'...
warning: templates not found in /usr/share/git-core/templates
fatal: unable to access 'https://github.com/openshift-hyperfleet/architecture.git/': Failed to connect to github.com port 443 after 133416 ms: Couldn't connect to server


Comment @coderabbitai help to get the list of available commands and usage tips.

@ciaranRoche
Copy link
Copy Markdown
Contributor Author

/retest

Copy LICENSE into /licenses for Konflux preflight HasLicense check.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ciaranRoche ciaranRoche force-pushed the HYPERFLEET-1094-add-licenses branch from b8dcffb to 27c2f55 Compare May 15, 2026 11:51
@rafabene
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rafabene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit ca05027 into main May 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants