Update github.com/lufia/plan9stats digest to c963978#133
Update github.com/lufia/plan9stats digest to c963978#133red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR. I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughSummary by CodeRabbit
WalkthroughA single indirect dependency in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: updates to go.mod needed, disabled by -mod=readonly; to update it:\n\tgo mod tidy\n" Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 102: The go.mod change added/modified the dependency entry
"github.com/lufia/plan9stats c963978e514e" but go.sum wasn't updated; run "go
mod tidy" to regenerate and add the missing checksums, verify the version string
is a valid module version (replace the short commit ref with a proper
pseudo-version if needed), and commit the updated go.sum so checksum
verification succeeds during builds.
- Line 102: go.mod contains an invalid bare commit hash for the dependency
github.com/lufia/plan9stats (c963978e514e) which breaks module versioning;
replace the bare hash with a valid pseudo-version or reconcile modules by
running `go mod tidy` so go.mod matches go.sum (either restore the
pseudo-version v0.0.0-20211012122336-39d0f177ccd0 referenced in go.sum or update
to the newer pseudo-version used by other services
v0.0.0-20251013123823-9fd1530e3ec3), ensuring the entry for
github.com/lufia/plan9stats is a proper pseudo-version string rather than a raw
commit hash.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 08a3748d-2a50-4f3d-a5a6-145bfe4e0d89
📒 Files selected for processing (1)
go.mod
| github.com/lann/ps v0.0.0-20150810152359-62de8c46ede0 // indirect | ||
| github.com/leodido/go-urn v1.4.0 // indirect | ||
| github.com/lufia/plan9stats v0.0.0-20211012122336-39d0f177ccd0 // indirect | ||
| github.com/lufia/plan9stats c963978e514e // indirect |
There was a problem hiding this comment.
Missing go.sum update for dependency change.
When go.mod is updated with a new dependency version, the corresponding go.sum file should also be updated to include the checksums for the new version. The absence of go.sum changes in this PR suggests the module files may not be in a valid state, which could cause checksum verification failures during builds.
After correcting the version format, run go mod tidy to regenerate the go.sum entries:
go mod tidyThis will ensure the go.sum file contains the proper checksums for the updated dependency.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 102, The go.mod change added/modified the dependency entry
"github.com/lufia/plan9stats c963978e514e" but go.sum wasn't updated; run "go
mod tidy" to regenerate and add the missing checksums, verify the version string
is a valid module version (replace the short commit ref with a proper
pseudo-version if needed), and commit the updated go.sum so checksum
verification succeeds during builds.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Fetch the correct pseudo-version for the commit hash c963978e514e
# Get commit timestamp and construct proper pseudo-version
git clone --quiet https://github.com/lufia/plan9stats.git /tmp/plan9stats 2>/dev/null || true
cd /tmp/plan9stats
# Verify the commit exists
if git cat-file -e c963978e514e^{commit} 2>/dev/null; then
# Get commit timestamp in the format Go expects
timestamp=$(git show -s --format=%cd --date=format:'%Y%m%d%H%M%S' c963978e514e)
short_hash=$(git rev-parse --short=12 c963978e514e)
echo "Correct pseudo-version format: v0.0.0-${timestamp}-${short_hash}"
else
echo "ERROR: Commit c963978e514e not found in repository"
fi
# Clean up
cd - > /dev/null
rm -rf /tmp/plan9statsRepository: openshift-hyperfleet/hyperfleet-api
Length of output: 253
🏁 Script executed:
#!/bin/bash
# Check the actual go.mod content around line 102
echo "=== go.mod around line 102 ==="
sed -n '100,105p' go.mod
echo -e "\n=== Check for plan9stats in go.mod ==="
rg 'plan9stats' go.mod
echo -e "\n=== Check for plan9stats in go.sum ==="
if [ -f go.sum ]; then
rg 'plan9stats' go.sum || echo "No plan9stats entries in go.sum"
else
echo "go.sum not found"
fiRepository: openshift-hyperfleet/hyperfleet-api
Length of output: 810
🏁 Script executed (no clone):
# Verify if a bare commit hash without pseudo-version prefix is valid in Go modules
cat <<'EOF'
According to Go module versioning specification (https://go.dev/doc/modules/version-numbers):
- Pseudo-versions must follow format: vX.Y.Z-prerelease+metadata or v0.0.0-YYYYMMDDHHMMSS-hash
- Bare commit hashes (like c963978e514e) are NOT valid module versions
Go will reject bare hashes and require `go get module@commit` syntax during fetch,
which is then converted to a pseudo-version in go.mod.
The version "c963978e514e" appears malformed. If this came from `go get`, Go itself
would have converted it to a proper pseudo-version during resolution.
EOF
Length of output: 585
Invalid Go module version format — go.mod and go.sum are mismatched.
Line 102 contains c963978e514e, a bare commit hash that violates Go's module versioning specification. Valid pseudo-versions must follow the format v0.0.0-YYYYMMDDHHMMSS-hash. Your go.sum still references the proper pseudo-version v0.0.0-20211012122336-39d0f177ccd0, but go.mod's bare hash will cause go mod tidy and go build to fail. Additionally, other hyperfleet services (sentinel, adapter, broker) already use the newer version v0.0.0-20251013123823-9fd1530e3ec3. Either revert go.mod to match go.sum's version, or run go mod tidy to reconcile both files with a valid pseudo-version.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 102, go.mod contains an invalid bare commit hash for the
dependency github.com/lufia/plan9stats (c963978e514e) which breaks module
versioning; replace the bare hash with a valid pseudo-version or reconcile
modules by running `go mod tidy` so go.mod matches go.sum (either restore the
pseudo-version v0.0.0-20211012122336-39d0f177ccd0 referenced in go.sum or update
to the newer pseudo-version used by other services
v0.0.0-20251013123823-9fd1530e3ec3), ensuring the entry for
github.com/lufia/plan9stats is a proper pseudo-version string rather than a raw
commit hash.
|
Closing: superseded by renovate.json config in #158 (HYPERFLEET-1095). MintMaker will re-create grouped updates on the next Monday cycle. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for the If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
red-hat-konflux-kflux-prd-rh02
Bot
deleted the
konflux/mintmaker/main/github.com-lufia-plan9stats-digest
branch
1 participant
This PR contains the following updates:
39d0f17→c963978Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.