Skip to content

HYPERFLEET-978 - feat: (2/2) Include routes in API for PUT status updates #135

Draft
ma-hill wants to merge 1 commit into
openshift-hyperfleet:mainfrom
ma-hill:HYPERFLEET-978
Draft

HYPERFLEET-978 - feat: (2/2) Include routes in API for PUT status updates #135
ma-hill wants to merge 1 commit into
openshift-hyperfleet:mainfrom
ma-hill:HYPERFLEET-978

Conversation

@ma-hill
Copy link
Copy Markdown
Contributor

@ma-hill ma-hill commented May 12, 2026

Summary

Removes the POST endpoints for adapter status updates on clusters and nodepools, keeping only PUT endpoints. This simplifies the API surface by eliminating redundancy. Adapters now exclusively use PUT to report status.

Changes

  • Removed POST /api/hyperfleet/v1/clusters/{cluster_id}/statuses endpoint from OpenAPI spec
  • Removed POST /api/hyperfleet/v1/clusters/{cluster_id}/nodepools/{nodepool_id}/statuses endpoint from OpenAPI spec
  • Updated PUT endpoint descriptions to clarify that adapters call these after each evaluation to upsert status by adapter name
  • Removed POST route handlers from plugins/clusters/plugin.go for both cluster and nodepool statuses
  • Updated all integration tests to use PutClusterStatuses and PutNodePoolStatuses instead of PostClusterStatuses and PostNodePoolStatuses
  • Updated OpenAPI version from 1.0.12 to 1.0.13
  • Updated comment references from "POSTs" to "PUTs" in AdapterStatus and Condition type descriptions

Test Plan

  • Unit tests added/updated
  • make test-all passes
  • make lint passes
  • API spec changes validated with make generate-all
  • Integration tests updated and passing

Jira Issue

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 12, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 9afffded-9789-4a0c-8e27-f0f843db5799

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign crizzo71 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign crizzo71 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ma-hill ma-hill changed the title HYPERFLEET-978 - feat: Use PUT for status updates (2/2) HYPERFLEET-978 - feat: (2/2) Include routes in API for PUT status updates May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant