HYPERFLEET-978 - feat: (2/2) Include routes in API for PUT status updates #135
HYPERFLEET-978 - feat: (2/2) Include routes in API for PUT status updates #135ma-hill wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary
Removes the POST endpoints for adapter status updates on clusters and nodepools, keeping only PUT endpoints. This simplifies the API surface by eliminating redundancy. Adapters now exclusively use PUT to report status.
Changes
POST /api/hyperfleet/v1/clusters/{cluster_id}/statusesendpoint from OpenAPI specPOST /api/hyperfleet/v1/clusters/{cluster_id}/nodepools/{nodepool_id}/statusesendpoint from OpenAPI specplugins/clusters/plugin.gofor both cluster and nodepool statusesPutClusterStatusesandPutNodePoolStatusesinstead ofPostClusterStatusesandPostNodePoolStatusesTest Plan
make test-allpassesmake lintpassesmake generate-allJira Issue