Update google.golang.org/genproto/googleapis/rpc digest to 3700d41#136
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR. I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: updates to go.mod needed, disabled by -mod=readonly; to update it:\n\tgo mod tidy\n" Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 149: The go.mod entry for module symbol
google.golang.org/genproto/googleapis/rpc uses a malformed pseudo-version
(3700d4141b60); update it to a valid pseudo-version matching go.sum (e.g.,
v0.0.0-20260401024825-3700d4141b60) so both files reference the same version,
then run go mod tidy (or go get
google.golang.org/genproto@v0.0.0-20260401024825-3700d4141b60) to regenerate
go.sum and resolve the mismatch; finally confirm this genproto version is
intentionally different from the versions used in hyperfleet-sentinel,
hyperfleet-adapter, and hyperfleet-broker and adjust for cross-repo consistency
if needed.
- Line 149: Replace the bare commit hash for the module
google.golang.org/genproto/googleapis/rpc in go.mod with the proper
pseudo-version that matches go.sum (e.g., v0.0.0-20260401024825-9d38bb4040a9) or
run `go mod tidy` to let Go compute and sync the correct pseudo-version; ensure
the entry in go.mod exactly matches the pseudo-version found in go.sum so
dependency resolution succeeds.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 067cf23d-e158-44ce-b774-c630048f4a20
📒 Files selected for processing (1)
go.mod
| golang.org/x/text v0.35.0 // indirect | ||
| google.golang.org/genproto/googleapis/api v0.0.0-20260401024825-9d38bb4040a9 // indirect | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20260401024825-9d38bb4040a9 // indirect | ||
| google.golang.org/genproto/googleapis/rpc 3700d4141b60 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check googleapis/rpc versions across HyperFleet repositories
echo "=== Checking genproto/googleapis/rpc versions across repos ==="
# Check hyperfleet-api (this repo)
echo -e "\n--- hyperfleet-api ---"
rg -n "google.golang.org/genproto/googleapis/rpc" go.mod go.sum
# Search for any direct usage of googleapis/rpc in this codebase
echo -e "\n=== Checking for direct imports of googleapis/rpc ==="
rg -n --type=go "google.golang.org/genproto/googleapis/rpc"Repository: openshift-hyperfleet/hyperfleet-api
Length of output: 579
Fix malformed version syntax in go.mod and resolve dependency mismatch with go.sum.
The current go.mod entry 3700d4141b60 is not a valid Go pseudo-version format. The go.sum file still references v0.0.0-20260401024825-9d38bb4040a9, creating a mismatch that will cause module resolution issues. Ensure the entry is reformatted to a proper pseudo-version (e.g., v0.0.0-20260401024825-3700d4141b60), and verify that both files reference the same version consistently.
Additionally, after correcting the syntax, verify that this genproto version is intentionally different from the versions in related repositories:
hyperfleet-sentinelandhyperfleet-adaptercurrently usev0.0.0-20260401024825-9d38bb4040a9hyperfleet-brokerusesv0.0.0-20260209200024-4cfbd4190f57
Cross-repo version consistency for transitive dependencies should be validated to avoid unexpected behavior during dependency resolution.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 149, The go.mod entry for module symbol
google.golang.org/genproto/googleapis/rpc uses a malformed pseudo-version
(3700d4141b60); update it to a valid pseudo-version matching go.sum (e.g.,
v0.0.0-20260401024825-3700d4141b60) so both files reference the same version,
then run go mod tidy (or go get
google.golang.org/genproto@v0.0.0-20260401024825-3700d4141b60) to regenerate
go.sum and resolve the mismatch; finally confirm this genproto version is
intentionally different from the versions used in hyperfleet-sentinel,
hyperfleet-adapter, and hyperfleet-broker and adjust for cross-repo consistency
if needed.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Validate go.mod syntax and retrieve correct pseudo-version for the commit
# Check if go.mod is valid
echo "=== Validating go.mod syntax ==="
go mod verify || echo "go mod verify failed"
# Attempt to retrieve correct pseudo-version for commit 3700d4141b60
echo -e "\n=== Checking commit 3700d4141b60 in googleapis/go-genproto ==="
# Note: This commit should have a timestamp associated with it
git ls-remote https://github.com/googleapis/go-genproto.git 3700d4141b60* || echo "Commit lookup failed"
# Check what go list reports for this module
echo -e "\n=== Checking module version via go list ==="
go list -m google.golang.org/genproto/googleapis/rpc || echo "go list failed"Repository: openshift-hyperfleet/hyperfleet-api
Length of output: 332
🏁 Script executed:
#!/bin/bash
# Check the actual go.mod file around line 149
echo "=== go.mod lines 145-155 ==="
sed -n '145,155p' go.mod
echo -e "\n=== Searching for genproto/googleapis/rpc in go.sum ==="
grep "google.golang.org/genproto/googleapis/rpc" go.sum | head -5Repository: openshift-hyperfleet/hyperfleet-api
Length of output: 869
Version mismatch in go.mod and go.sum will break dependency resolution.
Line 149 specifies a bare commit hash 3700d4141b60 for google.golang.org/genproto/googleapis/rpc, but go.sum contains the conflicting entry v0.0.0-20260401024825-9d38bb4040a9. This mismatch prevents successful module resolution and requires go mod tidy to fix.
Go module version specifications must use proper pseudo-version format (v0.0.0-yyyymmddhhmmss-commithash) and be consistent with go.sum entries.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 149, Replace the bare commit hash for the module
google.golang.org/genproto/googleapis/rpc in go.mod with the proper
pseudo-version that matches go.sum (e.g., v0.0.0-20260401024825-9d38bb4040a9) or
run `go mod tidy` to let Go compute and sync the correct pseudo-version; ensure
the entry in go.mod exactly matches the pseudo-version found in go.sum so
dependency resolution succeeds.
|
Closing: superseded by renovate.json config in #158 (HYPERFLEET-1095). MintMaker will re-create grouped updates on the next Monday cycle. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for the If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
red-hat-konflux-kflux-prd-rh02
Bot
deleted the
konflux/mintmaker/main/google.golang.org-genproto-googleapis-rpc-digest
branch
1 participant
This PR contains the following updates:
9d38bb4→3700d41Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.