ai-eval: DNM, feat(EP-1914): API types, controller implementation, e2e by openshift-app-platform-shift[bot] · Pull Request #423 · openshift/cert-manager-operator

openshift-app-platform-shift · 2026-05-08T13:06:29Z

Summary

Adds comprehensive E2E tests for the TrustManager controller using Ginkgo v2, following the existing IstioCSR E2E test patterns
Tests cover basic deployment, status verification, SecretTargets RBAC configuration, DefaultCAPackage ConfigMap creation, and non-destructive CR deletion behavior
Includes test data YAML manifests for different TrustManager CR configurations

Test plan

Verify go build -tags e2e ./test/e2e/... succeeds
Verify go vet -tags e2e ./test/e2e/... passes
Run E2E tests with TrustManager feature gate enabled: make test-e2e E2E_GINKGO_LABEL_FILTER="Feature:TrustManager"
Verify tests pass on a cluster with the TrustManager controller deployed

🤖 Generated with Claude Code

Introduces the TrustManager CRD (trustmanagers.operator.openshift.io/v1alpha1) as specified in the enhancement proposal (EP-1914). This cluster-scoped singleton resource enables day-2 installation and configuration of the trust-manager operand. Key additions: - TrustManager types with spec fields: logLevel, logFormat, trustNamespace, secretTargets, filterExpiredCertificates, defaultCAPackage, resources, affinity, tolerations, nodeSelector - SecretTargetsConfig with Custom/Disabled policy and authorizedSecrets - DefaultCAPackageConfig for OpenShift trusted CA bundle integration - FeatureTrustManager feature gate (Alpha, default disabled) - CRD manifest, deepcopy, client/lister/informer generation - Integration tests for CRD validation (status defaults, singleton, scope, immutability) - YAML test suite covering create/update validation scenarios Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Implements the controller-runtime based reconciler for the TrustManager CRD. The controller watches trustmanagers.operator.openshift.io resources and reconciles the trust-manager operand deployment in the cert-manager namespace, including ServiceAccount, RBAC, Certificates, Services, DefaultCAPackage ConfigMap, and Deployment resources. The controller follows the same patterns as the IstioCSR controller: - Feature-gated via FeatureTrustManager (Alpha, default disabled) - Separate controller-runtime manager with its own cache builder - Non-destructive cleanup on CR deletion per EP non-goals - Dynamic RBAC for SecretTargets policy - DefaultCAPackage integration with CNO trusted CA bundle injection Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Adds end-to-end tests for the TrustManager controller covering: - Basic trust-manager deployment with default configuration - Status field verification (Ready/Degraded conditions, observed state) - SecretTargets Custom policy with dynamic RBAC verification - DefaultCAPackage ConfigMap creation when policy is Enabled - Non-destructive cleanup on TrustManager CR deletion Tests follow the existing IstioCSR E2E test patterns using Ginkgo v2, polling helpers, and the dynamic resource loader. Test data YAML manifests are provided in testdata/trustmanager/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-ci-robot · 2026-05-08T13:06:34Z

@openshift-app-platform-shift[bot]: This pull request references CM-830 which is a valid jira issue.

Details

In response to this:

Summary

Adds comprehensive E2E tests for the TrustManager controller using Ginkgo v2, following the existing IstioCSR E2E test patterns

Tests cover basic deployment, status verification, SecretTargets RBAC configuration, DefaultCAPackage ConfigMap creation, and non-destructive CR deletion behavior

Includes test data YAML manifests for different TrustManager CR configurations

Related

Enhancement Proposal: CM-830: Integrate trust-manager with cert-manager-operator enhancements#1914

Depends on: API types (PR initial commit #1) and Controller implementation (PR OWNERS: add slaskawi #2)

Test plan

Verify go build -tags e2e ./test/e2e/... succeeds

Verify go vet -tags e2e ./test/e2e/... passes

Run E2E tests with TrustManager feature gate enabled: make test-e2e E2E_GINKGO_LABEL_FILTER="Feature:TrustManager"

Verify tests pass on a cluster with the TrustManager controller deployed

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-05-08T13:06:57Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-app-platform-shift[bot]
Once this PR has been reviewed and has the lgtm label, please assign bharath-b-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-05-08T13:07:01Z

Hi @openshift-app-platform-shift[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

swghosh · 2026-05-08T13:10:52Z

/retitle ai-eval: DNM, feat(EP-1914): API types, controller implementation, e2e

openshift-ci-robot · 2026-05-08T13:10:59Z

@openshift-app-platform-shift[bot]: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Summary

Adds comprehensive E2E tests for the TrustManager controller using Ginkgo v2, following the existing IstioCSR E2E test patterns

Tests cover basic deployment, status verification, SecretTargets RBAC configuration, DefaultCAPackage ConfigMap creation, and non-destructive CR deletion behavior

Includes test data YAML manifests for different TrustManager CR configurations

Related

Enhancement Proposal: CM-830: Integrate trust-manager with cert-manager-operator enhancements#1914

Depends on: API types (PR initial commit #1) and Controller implementation (PR OWNERS: add slaskawi #2)

Test plan

Verify go build -tags e2e ./test/e2e/... succeeds

Verify go vet -tags e2e ./test/e2e/... passes

Run E2E tests with TrustManager feature gate enabled: make test-e2e E2E_GINKGO_LABEL_FILTER="Feature:TrustManager"

Verify tests pass on a cluster with the TrustManager controller deployed

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

swghosh · 2026-05-08T13:12:26Z

This PR was authored/developed as a result of openshift/release#79009 rehearsal workflow because of input.Dockerfile trigger.

swghosh · 2026-05-08T13:20:59Z

/cc @arun717 @chiragkyal
per se https://docs.google.com/spreadsheets/d/1C_5dlcAKKkg2Pkmh2OT9f7CSkaWS6RhpbOfJkRhLUEU/edit?gid=0#gid=0

swghosh · 2026-05-08T19:52:56Z

/ok-to-test

swghosh · 2026-05-09T03:06:04Z

/ok-to-test

openshift-ci · 2026-05-09T05:04:29Z

@openshift-app-platform-shift[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-operator-tech-preview	`9bb579c`	link	false	`/test e2e-operator-tech-preview`
ci/prow/unit	`9bb579c`	link	true	`/test unit`
ci/prow/verify	`9bb579c`	link	true	`/test verify`
ci/prow/e2e-operator	`9bb579c`	link	true	`/test e2e-operator`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-app-platform-shift Bot and others added 3 commits May 8, 2026 12:46

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 8, 2026

openshift-ci Bot requested review from PillaiManish and TrilokGeer May 8, 2026 13:06

openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 8, 2026

openshift-ci Bot changed the title ~~CM-830: Add E2E tests for TrustManager controller~~ ai-eval: DNM, feat(EP-1914): API types, controller implementation, e2e May 8, 2026

openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 8, 2026

This was referenced May 8, 2026

CM-830: Add TrustManager API types for trust-manager operand #421

Closed

CM-830: Add TrustManager controller for trust-manager operand management #422

Closed

openshift-ci Bot requested review from arun717 and chiragkyal May 8, 2026 13:21

swghosh mentioned this pull request May 8, 2026

poc(prow): 🚢 ✴️ openshift-eng/oape-ai-e2e workflow openshift/release#79009

Open

2 tasks

openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2026

Conversation

openshift-app-platform-shift Bot commented May 8, 2026

Summary

Related

Test plan

Uh oh!

openshift-ci-robot commented May 8, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related

Test plan

Uh oh!

openshift-ci Bot commented May 8, 2026

Uh oh!

openshift-ci Bot commented May 8, 2026

Uh oh!

swghosh commented May 8, 2026

Uh oh!

openshift-ci-robot commented May 8, 2026

Summary

Related

Test plan

Uh oh!

swghosh commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

swghosh commented May 8, 2026

Uh oh!

swghosh commented May 8, 2026

Uh oh!

swghosh commented May 9, 2026

Uh oh!

openshift-ci Bot commented May 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

openshift-ci-robot commented May 8, 2026 •

edited by openshift-ci Bot

Loading

swghosh commented May 8, 2026 •

edited

Loading