Skip to content

fix: check .gopclntab before .data.rel.ro for PIE binaries #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiridanek wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −19
Open

fix: check .gopclntab before .data.rel.ro for PIE binaries #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 6 additions & 19 deletions internal/golang/goscan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,33 +52,20 @@ func _magicNumber(goVersion string) uint32 {

// Open a Go ELF executable and read .gopclntab
func ReadTable(fileName string, bi *buildinfo.BuildInfo) (*gosym.Table, error) {
// Default section label is .gopclntab
sectionLabel := ".gopclntab"

// If built with PIE and stripped, gopclntab is
// unlabeled and nested under .data.rel.ro.
for _, bs := range bi.Settings {
if bs.Key == "-buildmode" {
if bs.Value == "pie" {
sectionLabel = ".data.rel.ro"
}
break
}
}

exe, err := elf.Open(fileName)
if err != nil {
return nil, err
}
defer exe.Close()

section := exe.Section(sectionLabel)
// Go 1.26+ restores .gopclntab as a separate section even for PIE builds.
// Go <= 1.25 PIE binaries embed pclntab inside .data.rel.ro instead.
// Always check .gopclntab first, then fall back to .data.rel.ro.
section := exe.Section(".gopclntab")
if section == nil {
// binary may be built with -pie
sectionLabel = ".data.rel.ro"
section = exe.Section(sectionLabel)
section = exe.Section(".data.rel.ro")
if section == nil {
return nil, fmt.Errorf("could not read section .gopclntab from %s ", fileName)
return nil, fmt.Errorf("could not find .gopclntab or .data.rel.ro section in %s", fileName)
}
}
tableData, err := section.Data()
Expand Down