Skip to content

NO-ISSUE: Update github.com/openshift/hive/apis digest to a6c32a8#993

Open
red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
konflux/mintmaker/master/github.com-openshift-hive-apis-digest
Open

NO-ISSUE: Update github.com/openshift/hive/apis digest to a6c32a8#993
red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
konflux/mintmaker/master/github.com-openshift-hive-apis-digest

Conversation

@red-hat-konflux
Copy link
Copy Markdown

@red-hat-konflux red-hat-konflux Bot commented Apr 27, 2026

This PR contains the following updates:

Package Type Update Change
github.com/openshift/hive/apis require digest b10cc0da6c32a8

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@red-hat-konflux[bot]: This pull request explicitly references no jira issue.

Details

In response to this:

This PR contains the following updates:

Package Type Update Change
github.com/openshift/hive/apis require digest b10cc0dbd520da

[!WARNING]
Some dependencies could not be looked up. Check the warning logs for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

Walkthrough

The PR updates a single Go module dependency in go.mod: the github.com/openshift/hive/apis requirement is changed from a pseudo-version to a pinned revision (a6c32a8c8828).

Changes

Dependency Update

Layer / File(s) Summary
Dependency Pin
go.mod
github.com/openshift/hive/apis updated from pseudo-version v0.0.0-20260422161834-b10cc0dc2b46 to pinned revision a6c32a8c8828 (lines changed: +1/-1).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Test Structure And Quality ⚠️ Warning Test files lack assertion messages. Nearly all Expect() calls are missing meaningful failure messages that would help diagnose test failures. Add diagnostic messages to all assertions, e.g., Expect(err).NotTo(HaveOccurred(), "failed to create test pod"). This affects hundreds of assertions throughout test files.
Ipv6 And Disconnected Network Test Compatibility ⚠️ Warning New Ginkgo e2e tests added contain hardcoded IPv4 addresses (1.2.3.4, 2.3.4.5, 3.4.5.6, 192.186.126.10, 10.0.36.14) with no IPv6 adaptation. IPv6 field contains IPv4 address 9.9.9.9. Add IPv6 address variants to all test data. Use GetIPAddressFamily() or correctCIDRFamily() helpers to dynamically adapt tests. Use InIPv4ClusterContext() wrapper for IPv4-only tests. Use net.JoinHostPort() for URL building.
✅ Passed checks (10 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating a Go module dependency digest for github.com/openshift/hive/apis.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR updates dependencies in go.mod only. Test files are unchanged and already have stable, deterministic test names.
Microshift Test Compatibility ✅ Passed PR only modifies go.mod to update github.com/openshift/hive/apis dependency. No new Ginkgo e2e tests are being added, so the MicroShift Test Compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only updates go.mod dependencies (github.com/openshift/hive/apis). No new Ginkgo e2e tests are added, so the SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed This PR only modifies go.mod to update a dependency version. No deployment manifests, operator code, or controllers are added or modified. The custom check is not applicable.
Ote Binary Stdout Contract ✅ Passed Dependency update in go.mod. Hive/apis is unused. Logger properly configured with zap and GinkgoWriter. No stdout writes in main/test code.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/master/github.com-openshift-hive-apis-digest

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 27, 2026
@openshift-ci openshift-ci Bot requested review from eliorerz and eranco74 April 27, 2026 13:11
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign crystalchun for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 27, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 27, 2026

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shay23bra
Copy link
Copy Markdown

shay23bra commented Apr 27, 2026

Closing: MintMaker is generating bare commit hashes instead of Go pseudo-versions for hive/apis. See ACM-29247 / ACM-29261 / ACM-29244.

@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/hive/apis digest to bd520da NO-ISSUE: Update github.com/openshift/hive/apis digest to bd520da - autoclosed Apr 30, 2026
@red-hat-konflux red-hat-konflux Bot closed this Apr 30, 2026
@red-hat-konflux red-hat-konflux Bot deleted the konflux/mintmaker/master/github.com-openshift-hive-apis-digest branch April 30, 2026 20:20
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/hive/apis digest to bd520da - autoclosed NO-ISSUE: Update github.com/openshift/hive/apis digest to 52fd62d May 1, 2026
@red-hat-konflux red-hat-konflux Bot reopened this May 1, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-hive-apis-digest branch from 13e08b6 to ce6daf4 Compare May 1, 2026 00:20
@red-hat-konflux
Copy link
Copy Markdown
Author

red-hat-konflux Bot commented May 1, 2026

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum
Command failed: go get -t ./...
go: downloading github.com/openshift/hive/apis v0.0.0-20260506164003-a6c32a8c8828
go: downloading github.com/openshift/installer v1.4.21-pre2.0.20260112230456-1c2444827f23
go: github.com/openshift/cluster-api-provider-agent/controllers imports
	github.com/openshift/hive/apis/hive/v1 imports
	github.com/openshift/hive/apis/hive/v1/vsphere imports
	github.com/openshift/installer/pkg/types/vsphere: github.com/openshift/installer@v1.4.21-pre2.0.20260112230456-1c2444827f23: verifying module: github.com/openshift/installer@v1.4.21-pre2.0.20260112230456-1c2444827f23: reading https://sum.golang.org/lookup/github.com/openshift/installer@v1.4.21-pre2.0.20260112230456-1c2444827f23: 404 Not Found
	server response: not found: 

@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-hive-apis-digest branch from ce6daf4 to 13e08b6 Compare May 1, 2026 00:20
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-openshift-hive-apis-digest branch from 13e08b6 to ad83e24 Compare May 6, 2026 22:14
@red-hat-konflux red-hat-konflux Bot changed the title NO-ISSUE: Update github.com/openshift/hive/apis digest to 52fd62d NO-ISSUE: Update github.com/openshift/hive/apis digest to a6c32a8 May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants