OCPBUGS-62277: Requeue PerformanceStatus update when status write fails

[MarSik]

The old code logged an error when not able to save status, but it never retried. This caused stale conditions to be reported until the next reconcile (possibly long time in the future).

Summary by CodeRabbit

• Bug Fixes
  • Improved error recovery for status update failures by implementing a 30-second retry delay, enhancing system resilience when status synchronization encounters transient issues.

[coderabbitai]

Warning

Rate limit exceeded

@MarSik has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 54 minutes and 23 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e2575cb6-5674-4fd0-aacc-dcd82e34c87e

📥 Commits

Reviewing files that changed from the base of the PR and between 40bd7af and 06227d4.

📒 Files selected for processing (1)

• pkg/performanceprofile/controller/performanceprofile_controller.go

Walkthrough

A shared 30-second statusUpdateRequeueAfter constant is introduced and integrated into the reconcile control flow. When status update operations fail during component deployment, MCP validation, or condition updates, the controller now returns a requeue result with this delay instead of an empty requeue result.

Changes

Cohort / File(s)	Summary
Performance Profile Controller Reconciliation pkg/performanceprofile/controller/performanceprofile_controller.go	Adds statusUpdateRequeueAfter constant (30s delay) and modifies error handling in reconciliation so that StatusWriter.Update and StatusWriter.UpdateOwnedConditions failures trigger requeue with the specified delay instead of immediate error return.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Test Structure And Quality	❓ Inconclusive	Unable to execute git commands to verify changes in performanceprofile_controller.go and test files.	Provide git diff output or file contents to assess code changes and test coverage.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main change: adding requeue behavior when PerformanceStatus update fails, which matches the core modification in the controller.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR modifies only the main controller file without changing any test files. Existing test names are stable and deterministic, containing only static descriptive strings without dynamic content.
Microshift Test Compatibility	✅ Passed	PR modifies controller implementation logic only; no new Ginkgo e2e tests are added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This pull request does not add any new Ginkgo e2e tests. The changes are limited to updating the controller's reconciliation logic in performanceprofile_controller.go to handle status update failures with proper requeue behavior using a 30-second delay constant. Since the custom check is specifically designed to assess newly added Ginkgo e2e tests for Single Node OpenShift (SNO) compatibility, and no such tests were added in this PR, the check is not applicable and passes by default.
Topology-Aware Scheduling Compatibility	✅ Passed	PR changes only controller error handling logic with requeue delays; no scheduling constraints, affinity rules, or topology assumptions introduced.
Ote Binary Stdout Contract	✅ Passed	Pull request modifies controller reconciler methods with no stdout writes in process-level code, complying with OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. The changes are limited to controller implementation modifications, so the custom check does not apply.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@MarSik: This pull request references Jira Issue OCPBUGS-62277, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The old code logged an error when not able to save status, but it never retried. This caused stale conditions to be reported until the next reconcile (possibly long time in the future).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [MarSik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MarSik]

/jira refresh

[openshift-ci-robot]

@MarSik: This pull request references Jira Issue OCPBUGS-62277, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mrniranjan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@MarSik: This pull request references Jira Issue OCPBUGS-62277, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mrniranjan

Details

In response to this:

The old code logged an error when not able to save status, but it never retried. This caused stale conditions to be reported until the next reconcile (possibly long time in the future).

Summary by CodeRabbit

• Bug Fixes
• Improved error recovery for status update failures by implementing a 30-second retry delay, enhancing system resilience when status synchronization encounters transient issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[MarSik]

/cherry-pick release-4.22 release-4.21 release-4.20 release-4.19 release-4.18

[openshift-cherrypick-robot]

@MarSik: once the present PR merges, I will cherry-pick it on top of release-4.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.22 release-4.21 release-4.20 release-4.19 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[MarSik]

/retest-required

[MarSik]

/retest-required

[openshift-ci]

@MarSik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-hypershift-pao	06227d4	link	true	/test e2e-hypershift-pao

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.