[release-4.19] OCPBUGS-80419: Bump google.golang.org/grpc to v1.79.3#1501
Conversation
openshift-ci-robot
added
jira/severity-important
|
@ocp-sustaining-admins: This pull request references Jira Issue OCPBUGS-80419, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review Summary by QodoBump google.golang.org/grpc and update dependencies
WalkthroughsDescription• Bump google.golang.org/grpc to v1.75.1-sec.1 via replace directive • Update OpenTelemetry dependencies to v1.37.0 • Update golang.org/x dependencies to latest versions • Update cel.dev/expr and go-logr/logr to newer versions Diagramflowchart LR
A["go.mod dependencies"] -- "Update indirect deps" --> B["OpenTelemetry v1.37.0"]
A -- "Update indirect deps" --> C["golang.org/x packages"]
A -- "Add replace directive" --> D["grpc-go v1.75.1-sec.1"]
A -- "Update indirect deps" --> E["Other packages"]
File Changes1. go.mod
|
Code Review by Qodo
1. grpc version ambiguous
|
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @ocp-sustaining-admins. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ocp-sustaining-admins The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| // openshift/openshift-kni/debug-tools@v0.2.1 needs pinning of cadvisor; also gather-sysinfo.go needs to be fixed to allow usage of latest debug-tools | ||
| replace github.com/google/cadvisor => github.com/google/cadvisor v0.49.1 | ||
|
|
||
| replace google.golang.org/grpc => github.com/openshift-sustaining/grpc-go v1.75.1-sec.1 |
There was a problem hiding this comment.
1. Grpc version ambiguous 🐞 Bug ⚙ Maintainability
go.mod now declares google.golang.org/grpc v1.71.0 but replaces it with github.com/openshift-sustaining/grpc-go v1.75.1-sec.1, so the effective grpc code differs from the declared grpc version in the module graph. This makes dependency tracking and future go mod tidy/vendor regeneration error-prone because removing/altering the replace will silently drop back to v1.71.0.
Agent Prompt
### Issue description
`go.mod` declares `google.golang.org/grpc v1.71.0` but also replaces it with `github.com/openshift-sustaining/grpc-go v1.75.1-sec.1`, making the effective grpc code version differ from the declared grpc version.
### Issue Context
This discrepancy is also reflected in `vendor/modules.txt`, which will commonly be used by tooling/SBOM generation and can be silently reverted by future `go mod tidy`/`go mod vendor` changes if the `replace` line is touched.
### Fix Focus Areas
- go.mod[156-181]
- go.mod[240-244]
### What to change
- Update the declared `require google.golang.org/grpc ...` version to match the intended grpc version (and keep it aligned with the fork’s tag/base).
- Keep (or adjust) the `replace google.golang.org/grpc => github.com/openshift-sustaining/grpc-go ...` to the corresponding fork version.
- Re-run `go mod tidy` and `go mod vendor` to ensure `go.sum` and `vendor/modules.txt` are consistent with the final intended version.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
/ok-to-test |
openshift-ci
Bot
added
ok-to-test
|
@ocp-sustaining-admins: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cc @jmencak |
Well, we have no valid JIRA labels and the backporting does not seem to follow the standard backport practice from the fixed branch down to the unfixed branches. |
5 participants
This is an automated PR from the ARC system.
Go version used:
go1.23.12Patch applied:
github.com/openshift-sustaining/grpc-go@v1.75.1-sec.1Modules affected:
.The commands used to generate this PR were:
A member of the Red Hat Openshift Sustaining Team will review the PR and take appropriate action.