Skip to content

[release-4.17] OCPBUGS-80062: Bump google.golang.org/grpc to v1.79.3#1503

Open
ocp-sustaining-admins wants to merge 1 commit intoopenshift:release-4.17from
openshift-sustaining:release-4.17_CVE-2026-33186
Open

[release-4.17] OCPBUGS-80062: Bump google.golang.org/grpc to v1.79.3#1503
ocp-sustaining-admins wants to merge 1 commit intoopenshift:release-4.17from
openshift-sustaining:release-4.17_CVE-2026-33186

Conversation

@ocp-sustaining-admins
Copy link
Copy Markdown

This is an automated PR from the ARC system.

Go version used: go1.22.12

Patch applied: github.com/openshift-sustaining/grpc-go@v1.71.3-sec.1

Modules affected: .

The commands used to generate this PR were:

go mod edit -replace google.golang.org/grpc=github.com/openshift-sustaining/grpc-go@v1.71.3-sec.1
go mod tidy
go mod vendor

A member of the Red Hat Openshift Sustaining Team will review the PR and take appropriate action.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@ocp-sustaining-admins: This pull request references Jira Issue OCPBUGS-80062, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Not a Bug) instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-80062 to depend on a bug targeting a version in 4.18.0, 4.18.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated PR from the ARC system.

Go version used: go1.22.12

Patch applied: github.com/openshift-sustaining/grpc-go@v1.71.3-sec.1

Modules affected: .

The commands used to generate this PR were:

go mod edit -replace google.golang.org/grpc=github.com/openshift-sustaining/grpc-go@v1.71.3-sec.1
go mod tidy
go mod vendor

A member of the Red Hat Openshift Sustaining Team will review the PR and take appropriate action.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3d63b36f-a1eb-453f-9031-8e2da419335a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review
Copy link
Copy Markdown

Review Summary by Qodo

Bump google.golang.org/grpc to v1.70.0 with security updates

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Bump google.golang.org/grpc to v1.70.0 with security patch
• Update OpenTelemetry dependencies to v1.34.0
• Update golang.org/x dependencies for security fixes
• Add replace directive for openshift-sustaining grpc-go fork
Diagram
flowchart LR
  grpc["google.golang.org/grpc v1.63.2"] -->|"security patch"| grpc_new["v1.70.0"]
  otel["OpenTelemetry deps v1.23.0"] -->|"update"| otel_new["v1.34.0"]
  golang["golang.org/x deps"] -->|"security updates"| golang_new["latest versions"]
  grpc_new -->|"replace with"| fork["openshift-sustaining/grpc-go v1.71.3-sec.1"]
Loading

Grey Divider

File Changes

1. go.mod Dependencies +23/-21

Update dependencies with security patches

• Removed cloud.google.com/go/compute v1.24.0 dependency
• Updated cloud.google.com/go/compute/metadata from v0.2.3 to v0.6.0
• Bumped google.golang.org/grpc from v1.63.2 to v1.70.0
• Updated all OpenTelemetry packages to v1.34.0 (otel, otel/metric, otel/sdk, otel/trace)
• Added go.opentelemetry.io/auto/sdk v1.1.0 dependency
• Updated golang.org/x packages (crypto, mod, net, oauth2, sync, sys, term, text, tools) to latest
 versions
• Updated google.golang.org/protobuf from v1.33.0 to v1.36.4
• Added replace directive for google.golang.org/grpc pointing to openshift-sustaining fork
 v1.71.3-sec.1

go.mod


2. go.sum Dependencies +1465/-56

Update dependency checksums

• Updated checksums for all modified dependencies
• Added checksums for new dependencies (go.opentelemetry.io/auto/sdk)
• Removed checksums for deleted dependencies

go.sum


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented May 4, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

Grey Divider


Remediation recommended

1. gRPC version misreported 🐞 Bug ⛨ Security
Description
Because go.mod still requires google.golang.org/grpc v1.70.0 while replacing it with v1.71.3-sec.1,
the module version shown in the build list/vendor metadata remains v1.70.0 despite using forked
code.
This can confuse dependency/SBOM scanners and makes it easy to silently regress to v1.70.0 if the
replace directive is later removed.
Code

go.mod[250]

+replace google.golang.org/grpc => github.com/openshift-sustaining/grpc-go v1.71.3-sec.1
Evidence
The go.mod directives create a require/replace mismatch, and vendor/modules.txt records the
effective mapping as "grpc v1.70.0 => ... v1.71.3-sec.1", meaning tooling will often still report
grpc as v1.70.0.

go.mod[179-180]
go.mod[250-250]
vendor/modules.txt[936-938]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The module graph still "reports" `google.golang.org/grpc v1.70.0` even though the code is coming from the replacement fork/version. This can cause false positives/negatives in dependency reporting and makes future maintenance riskier.

### Issue Context
This repo vendors dependencies and records module mappings in `vendor/modules.txt`; the current mapping explicitly shows the mismatch.

### Fix Focus Areas
- go.mod[179-180]
- go.mod[250-250]
- vendor/modules.txt[936-938]

### Suggested change
Update the `require google.golang.org/grpc ...` line to the closest corresponding upstream version to the replacement (e.g., `v1.71.3` if that’s the base), keeping the `replace` to `github.com/openshift-sustaining/grpc-go v1.71.3-sec.1`, and re-run `go mod tidy` + `go mod vendor` so vendored metadata reflects the intended minimum version.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 4, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 4, 2026

Hi @ocp-sustaining-admins. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot requested review from MarSik and swatisehgal May 4, 2026 19:10
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ocp-sustaining-admins
Once this PR has been reviewed and has the lgtm label, please assign jmencak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants