[release-4.16] OCPBUGS-79950: Bump google.golang.org/grpc to v1.79.3

[ocp-sustaining-admins]

This is an automated PR from the ARC system.

Go version used: go1.21.13

Patch applied: github.com/openshift-sustaining/grpc-go@v1.67.3-sec.1

Modules affected: .

The commands used to generate this PR were:

go mod edit -replace google.golang.org/grpc=github.com/openshift-sustaining/grpc-go@v1.67.3-sec.1
go mod tidy
go mod vendor

A member of the Red Hat Openshift Sustaining Team will review the PR and take appropriate action.

[openshift-ci-robot]

@ocp-sustaining-admins: This pull request references Jira Issue OCPBUGS-79950, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Not a Bug) instead
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-79950 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated PR from the ARC system.

Go version used: go1.21.13

Patch applied: github.com/openshift-sustaining/grpc-go@v1.67.3-sec.1

Modules affected: .

The commands used to generate this PR were:

go mod edit -replace google.golang.org/grpc=github.com/openshift-sustaining/grpc-go@v1.67.3-sec.1
go mod tidy
go mod vendor

A member of the Red Hat Openshift Sustaining Team will review the PR and take appropriate action.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 58e54cc1-5977-4354-a5c8-0beee0d046b1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[qodo-code-review]

Review Summary by Qodo

Bump google.golang.org/grpc and dependencies for CVE-2026-33186

✨ Enhancement

Walkthroughs

Description

• Bump google.golang.org/grpc to v1.65.0 with security patch
• Update OpenTelemetry dependencies to v1.28.0
• Update golang.org/x packages to latest versions
• Add replace directive for grpc-go security fork

Diagram

flowchart LR
  grpc["google.golang.org/grpc<br/>v1.63.2 → v1.65.0"]
  otel["OpenTelemetry packages<br/>v1.23.0 → v1.28.0"]
  golang["golang.org/x packages<br/>updated to latest"]
  replace["Add grpc-go fork<br/>security patch"]
  grpc --> replace
  otel --> grpc
  golang --> grpc

Loading

File Changes

1. go.mod Dependencies +22/-21

Update grpc and dependencies for security patch

• Bumped google.golang.org/grpc from v1.63.2 to v1.65.0
• Updated OpenTelemetry packages (otel, otel/metric, otel/sdk, otel/trace) from v1.23.0 to v1.28.0
• Updated golang.org/x packages (crypto, net, oauth2, sync, sys, term, text, tools) to latest
 versions
• Removed cloud.google.com/go/compute dependency and updated cloud.google.com/go/compute/metadata to
 v0.5.2
• Updated other indirect dependencies (go-logr/logr, golang/glog, prometheus/client_model,
 google.golang.org/genproto, google.golang.org/protobuf)
• Added replace directive for google.golang.org/grpc pointing to
 github.com/openshift-sustaining/grpc-go v1.67.3-sec.1

go.mod

---

2. go.sum Dependencies +1433/-60

Update dependency checksums

• Updated checksums for all modified dependencies
• Added checksums for new dependency versions

go.sum

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (0)

1. gRPC version mismatch 🐞 Bug ≡ Correctness

Description

go.mod still selects google.golang.org/grpc v1.65.0 and then replaces it with
github.com/openshift-sustaining/grpc-go v1.67.3-sec.1, so this change does not move the codebase to
gRPC v1.79.3 and will not include any fixes introduced after v1.67.3.
If consumers/CI/security tracking expect v1.79.3 semantics or patches, they will not be present with
the current replace target.

Code

go.mod[R242-243]

+
+replace google.golang.org/grpc => github.com/openshift-sustaining/grpc-go v1.67.3-sec.1

Evidence

The PR pins the build to an openshift-sustaining fork at v1.67.3-sec.1 while the go.mod requirement
remains at v1.65.0, and go.sum confirms the forked module version being pulled; there is no
indication of v1.79.3 in the module definitions changed by this PR.

go.mod[170-174]
go.mod[243-243]
go.sum[1326-1327]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR does not actually move the dependency set to gRPC v1.79.3; it pins to a forked gRPC at v1.67.3-sec.1 while go.mod still lists google.golang.org/grpc v1.65.0.

## Issue Context
This can leave the repo without fixes/API changes introduced after v1.67.3 and can diverge from the stated intent of bumping gRPC to v1.79.3.

## Fix Focus Areas
- go.mod[170-174]
- go.mod[243-243]
- go.sum[1326-1327]

## Suggested fix
1. Confirm the intended effective gRPC version (e.g., truly v1.79.3 vs. an OCP-patched fork).
2. Update the `replace google.golang.org/grpc => ...` target to the intended patched version (or update the requirement to reflect the intended base version) so that the effective gRPC code matches the desired release.
3. Re-run `go mod tidy` (and vendoring if this repo vendors) to regenerate go.sum consistently.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

2. Replace missing rationale 🐞 Bug ⚙ Maintainability

Description

go.mod adds a replace to a non-canonical gRPC fork without any inline rationale, unlike the existing
replace blocks that document why pins exist.
This makes it harder to audit and increases the risk the security-related replace is accidentally
removed during future dependency maintenance.

Code

go.mod[243]

+replace google.golang.org/grpc => github.com/openshift-sustaining/grpc-go v1.67.3-sec.1

Evidence

The PR introduces an uncommented replace directive for gRPC, while other replace directives in the
same file are explicitly documented with comments explaining the pinning rationale.

go.mod[232-243]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The gRPC replace directive is added without a comment explaining why the fork/version is required.

## Issue Context
This repo already documents other replace/pin decisions directly in go.mod; the gRPC replace should follow the same pattern for auditability.

## Fix Focus Areas
- go.mod[232-243]

## Suggested fix
- Add a short comment above the gRPC `replace` explaining the reason (e.g., security backport context) and a tracking reference (bug/CVE ID), and optionally move it into the existing `replace (...)` block for consistency.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

[openshift-ci]

Hi @ocp-sustaining-admins. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ocp-sustaining-admins
Once this PR has been reviewed and has the lgtm label, please assign marsik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[qodo-code-review]

1. Grpc version mismatch 🐞 Bug ≡ Correctness

go.mod still selects google.golang.org/grpc v1.65.0 and then replaces it with
github.com/openshift-sustaining/grpc-go v1.67.3-sec.1, so this change does not move the codebase to
gRPC v1.79.3 and will not include any fixes introduced after v1.67.3.
If consumers/CI/security tracking expect v1.79.3 semantics or patches, they will not be present with
the current replace target.

Agent Prompt

## Issue description
The PR does not actually move the dependency set to gRPC v1.79.3; it pins to a forked gRPC at v1.67.3-sec.1 while go.mod still lists google.golang.org/grpc v1.65.0.

## Issue Context
This can leave the repo without fixes/API changes introduced after v1.67.3 and can diverge from the stated intent of bumping gRPC to v1.79.3.

## Fix Focus Areas
- go.mod[170-174]
- go.mod[243-243]
- go.sum[1326-1327]

## Suggested fix
1. Confirm the intended effective gRPC version (e.g., truly v1.79.3 vs. an OCP-patched fork).
2. Update the `replace google.golang.org/grpc => ...` target to the intended patched version (or update the requirement to reflect the intended base version) so that the effective gRPC code matches the desired release.
3. Re-run `go mod tidy` (and vendoring if this repo vendors) to regenerate go.sum consistently.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools