Skip to content

[release-4.22] OCPBUGS-77040: Add AWS ISO domains to konnectivity IsCloudAPI#8447

Open
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-8251-to-release-4.22
Open

[release-4.22] OCPBUGS-77040: Add AWS ISO domains to konnectivity IsCloudAPI#8447
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-8251-to-release-4.22

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #8251

/assign csrwng

The konnectivity proxy was missing AWS ISO (classified) region domains
from its cloud API detection. This prevented the ingress operator from
adding these domains to the NO_PROXY list, blocking direct communication
with endpoints in those namespaces.

Add the following AWS ISO domain suffixes:
- .c2s.ic.gov (AWS ISO / C2S)
- .hci.ic.gov (AWS ISO / HCI)
- .sc2s.sgov.gov (AWS ISO-B / SC2S)

Fixes: OCPBUGS-77040

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug OCPBUGS-77040 on the Jira server at https://redhat.atlassian.net. No known errors were detected, please see the full error message for details.

Full error message. request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":["QA Contact: User 'Yu Li' is not valid for this user picker."],"errors":{"customfield_10470":"User 'Yu Li' is not valid for this user picker."}}

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

This is an automated cherry-pick of #8251

/assign csrwng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 74b82535-a961-4980-866c-352896fa842c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from jparrill and sjenning May 6, 2026 20:09
@openshift-ci openshift-ci Bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels May 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.76%. Comparing base (41f254c) to head (79bb7b9).
⚠️ Report is 8 commits behind head on release-4.22.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-4.22    #8447   +/-   ##
=============================================
  Coverage         34.76%   34.76%           
=============================================
  Files               767      767           
  Lines             93314    93317    +3     
=============================================
+ Hits              32442    32445    +3     
  Misses            58196    58196           
  Partials           2676     2676           
Files with missing lines Coverage Δ
support/konnectivityproxy/dialer.go 25.66% <100.00%> (+0.85%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2026
@csrwng csrwng added approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels May 7, 2026
@csrwng
Copy link
Copy Markdown
Contributor

csrwng commented May 7, 2026

/verified by unit test

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 7, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@csrwng: This PR has been marked as verified by unit test.

Details

In response to this:

/verified by unit test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants