WIP: BYOK via MCP — knowledge-type MCP servers#2920
Draft
onmete wants to merge 1 commit into
Draft
Conversation
…retrieval Add support for MCP servers as knowledge sources (BYOK) with two retrieval modes: - `retrieval_mode: always` — forced retrieval on every query, results injected as RAG context (like current reference_content pipeline) - `retrieval_mode: on_demand` — exposed as LLM tool with augmented description via knowledge_description config field Config changes (MCPServerConfig): - type: tool (default) | knowledge - retrieval_mode: always | on_demand - search_tool: which MCP tool to call for retrieval - knowledge_description: context for on_demand mode - max_chunks, priority: retrieval control levers Includes POC setup with Qdrant + mcp-server-qdrant demonstrating the end-to-end flow. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POC / draft exploring BYOK (Bring Your Own Knowledge) through MCP as an alternative to the current file-based FAISS index approach.
What this adds:
type: knowledgeonMCPServerConfig— marks an MCP server as a knowledge sourceretrieval_mode: always— forced retrieval on every query, results injected as RAG context (same pattern as currentreference_content)retrieval_mode: on_demand— exposed as regular LLM tool, withknowledge_descriptionaugmenting the tool description so the model knows when to use itsearch_tool,max_chunks,priority— control levers for retrieval behaviorpoc/byok-mcp/) demonstrating the end-to-end flow with Qdrant + mcp-server-qdrantConfig example:
What this proves:
What this does NOT do:
Context
Related to the OKP integration proposal (#2914) and ongoing BYOK architecture discussions.
Test plan
retrieve_from_knowledge_mcpsMade with Cursor