Skip to content

OCPERT-356: Enable Jira Notificator for 4.22#978

Open
tomasdavidorg wants to merge 2 commits intoopenshift:mainfrom
tomasdavidorg:OCPERT-356
Open

OCPERT-356: Enable Jira Notificator for 4.22#978
tomasdavidorg wants to merge 2 commits intoopenshift:mainfrom
tomasdavidorg:OCPERT-356

Conversation

@tomasdavidorg tomasdavidorg added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 30, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 30, 2026

@tomasdavidorg: This pull request references OCPERT-356 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPERT-356

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 52644d6a-0e59-40f7-8c2e-fad8b6e69f84

📥 Commits

Reviewing files that changed from the base of the PR and between 0fe87f4 and 9ff09f6.

📒 Files selected for processing (1)
  • tests/test_jira_notificator.py

Walkthrough

Updated the JQL filter construction in the Jira notificator to include an additional "Target Version" value (4.22.z) in the ON_QA status query. No other filtering logic or notification behavior changed.

Changes

Cohort / File(s) Summary
Jira Filter Update
oar/notificator/jira_notificator.py
Added 4.22.z to the 'Target Version' values in the status = ON_QA JQL produced by NotificationService.get_on_qa_filter(...).
Tests Updated
tests/test_jira_notificator.py
Updated assertions to expect 4.22.z included in the 'Target Version' list for test_get_on_qa_filter cases.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from barboras7 and rioliu-rh March 30, 2026 12:53
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tomasdavidorg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 30, 2026

@tomasdavidorg: This pull request references OCPERT-356 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPERT-356

Merge after 4.22.z exists for the field Target Version.

https://redhat.atlassian.net/issues/?jql=project+%3D+OCPBUGS+AND+issuetype+in+%28Bug%2C+Vulnerability%29+AND+status+%3D+ON_QA+AND+%27Target+Version%27+in+%284.12.z%2C+4.13.z%2C+4.14.z%2C+4.15.z%2C+4.16.z%2C+4.17.z%2C+4.18.z%2C+4.19.z%2C+4.20.z%2C+4.21.z%2C+4.22.z%29&atlOrigin=eyJpIjoiZTA1YWM0NDRlOGQ0NDQzZmFjMTZjYjhmZmJmNzNjOGUiLCJwIjoiaiJ9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@oar/notificator/jira_notificator.py`:
- Line 637: The test assertions in
tests/test_jira_notificator.py::test_get_on_qa_filter must be updated to match
the implementation change that added "4.22.z" to the JQL; update both hardcoded
expected JQL strings in that test to include 4.22.z in the 'Target Version' list
so they match the string produced by the jira_notificator.get_on_qa_filter (the
diff shows the updated JQL fragment "AND status = ON_QA AND 'Target Version' in
(4.12.z, ..., 4.22.z)").
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7712d740-0f95-4d36-b60e-3ca37d631739

📥 Commits

Reviewing files that changed from the base of the PR and between 08330c7 and 0fe87f4.

📒 Files selected for processing (1)
  • oar/notificator/jira_notificator.py

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 30, 2026

@tomasdavidorg: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants