OCPERT-356: Enable Jira Notificator for 4.22#978
OCPERT-356: Enable Jira Notificator for 4.22#978tomasdavidorg wants to merge 2 commits intoopenshift:mainfrom
Conversation
|
@tomasdavidorg: This pull request references OCPERT-356 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated the JQL filter construction in the Jira notificator to include an additional "Target Version" value ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@tomasdavidorg: This pull request references OCPERT-356 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@oar/notificator/jira_notificator.py`:
- Line 637: The test assertions in
tests/test_jira_notificator.py::test_get_on_qa_filter must be updated to match
the implementation change that added "4.22.z" to the JQL; update both hardcoded
expected JQL strings in that test to include 4.22.z in the 'Target Version' list
so they match the string produced by the jira_notificator.get_on_qa_filter (the
diff shows the updated JQL fragment "AND status = ON_QA AND 'Target Version' in
(4.12.z, ..., 4.22.z)").
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7712d740-0f95-4d36-b60e-3ca37d631739
📒 Files selected for processing (1)
oar/notificator/jira_notificator.py
|
@tomasdavidorg: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://redhat.atlassian.net/browse/OCPERT-356
Merge after
4.22.zexists for the fieldTarget Version.https://redhat.atlassian.net/issues/?jql=project+%3D+OCPBUGS+AND+issuetype+in+%28Bug%2C+Vulnerability%29+AND+status+%3D+ON_QA+AND+%27Target+Version%27+in+%284.12.z%2C+4.13.z%2C+4.14.z%2C+4.15.z%2C+4.16.z%2C+4.17.z%2C+4.18.z%2C+4.19.z%2C+4.20.z%2C+4.21.z%2C+4.22.z%29&atlOrigin=eyJpIjoiZTA1YWM0NDRlOGQ0NDQzZmFjMTZjYjhmZmJmNzNjOGUiLCJwIjoiaiJ9