OCPBUGS-85344: enable karpenter tests for hypershift e2e-aws on 4.22#79051
OCPBUGS-85344: enable karpenter tests for hypershift e2e-aws on 4.22#79051enxebre wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@enxebre: This pull request references Jira Issue OCPBUGS-85344, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a new environment variable ChangesKarpenter Test Flag Propagation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
enxebre
force-pushed
the
hypershift-karpenter-4-22
branch
from
98b452e to
0721668
Compare
|
/lgtm |
Set RUN_KARPENTER_TESTS=true in the e2e-aws-4-22 test env in the main config. This allows the karpenter e2e tests to run against 4.22 hosted clusters when the operator is built from main. Depends on: openshift/hypershift#8466 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
enxebre
force-pushed
the
hypershift-karpenter-4-22
branch
from
0721668 to
116ecda
Compare
|
[REHEARSALNOTIFIER]
A total of 157 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@enxebre: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clebs, csrwng, enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Summary
RUN_KARPENTER_TESTS=trueenv var to thee2e-awstest in the hypershift release-4.22 CI configkarpenter.hypershift.openshift.io/v1) only exists on main, but can be tested against 4.22 clusters with this gateContext
Depends on openshift/hypershift#8466 which adds the
RUN_KARPENTER_TESTSenv var check to lower the version gate from 4.23 to 4.22 for karpenter tests.Fixes https://issues.redhat.com/browse/OCPBUGS-85344
Test plan
RUN_KARPENTER_TESTS=trueand runs karpenter tests against 4.22 clusters🤖 Generated with Claude Code
Enables running Karpenter e2e tests for HyperShift 4.22 in the OpenShift CI configuration. The PR updates HyperShift CI to set RUN_KARPENTER_TESTS: "true" for the e2e-aws-4-22 job (ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml), and adds the RUN_KARPENTER_TESTS environment variable (default "false") in the hypershift AWS nested e2e step definition (ci-operator/step-registry/hypershift/aws/run-e2e/nested/hypershift-aws-run-e2e-nested-ref.yaml). Practically, this lets the OpenShift CI run Karpenter e2e tests against 4.22 hosted clusters when the HyperShift operator is built from main — relying on the dependent HyperShift change that implements the gate and lowers the version requirement from 4.23 to 4.22. Fixes OCPBUGS-85344.
Test plan: ensure presubmit CI passes and verify the e2e-aws job picks up RUN_KARPENTER_TESTS=true and executes Karpenter tests against 4.22 clusters.