WIP: Fix BoostRepoConnect fallback to use PrepareRepo instead of ConnectToRepo (#8279)

[kaovilai]

Note

Accepted fix in upstream vmware-tanzu/velero will be prioritized/preferred over this cherry-pick.

Problem

When BoostRepoConnect's Open() fast path fails (e.g., stale local kopia config after BSL prefix change), it falls back to ConnectToRepo which only connects (Init with createNew=false). If no kopia repository exists at the new storage location, this fails with:

error to initialize data path: error to boost backup repository connection
  ts-dpa-1-test-prefix-bug-kopia: error to connect backup repo: error to connect
  repo with storage: error to connect to repository: repository not initialized
  in the provided storage

This is the error seen in vmware-tanzu/velero#8279.

Root Cause

BoostRepoConnect (pkg/repository/provider/unified_repo.go) falls back to ConnectToRepo (connect-only) instead of PrepareRepo (connect-then-init). The existing invalidation logic (vmware-tanzu#7380) and BackupRepository reconciliation (PrepareRepo) are correct — the bug is only in the backup data path's fallback.

Fix

One-line change: swap ConnectToRepo for PrepareRepo in BoostRepoConnect's fallback path. This ensures that when the local kopia config is stale, BoostRepoConnect will initialize a new repository at the new location if one doesn't exist — matching the BackupRepository controller's reconciliation behavior.

Complementary to

• vmware-tanzu/velero#9236 — fixes controller-side startup validation (detects stale repos when Velero wasn't running during BSL change)
• vmware-tanzu/velero#7380 — fixes BSL create event triggering BackupRepository invalidation

This fix addresses the data path fallback so BoostRepoConnect can handle uninitialized repos regardless of controller state.

Tests Added

• TestInvalidateBackupReposForBSL — verifies invalidateBackupReposForBSL() patches matching repos to NotReady
• TestCheckNotReadyRepoUpdatesIdentifierOnPrefixChange — restic repo identifier update on prefix change
• TestCheckNotReadyRepoKopiaUpdatesIdentifierOnPrefixChange — kopia repo identifier update on prefix change
• TestBSLDeleteRecreateWithNewPrefix — full BSL delete/recreate cycle end-to-end
• TestBoostRepoConnectInitializesWhenRepoNotFound — verifies BoostRepoConnect initializes repo when not found at new location

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ef565365-2f7a-4c28-becb-195d0137d31e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [kaovilai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment