forked from DuDigital/react-native-zoomable-view
-
Notifications
You must be signed in to change notification settings - Fork 62
Reanimated #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thomasttvo
wants to merge
38
commits into
thomas/no-use-before-define
Choose a base branch
from
thomas/reanimated
base: thomas/no-use-before-define
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reanimated #151
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
fa598a6
reanimated
d1c21ee
set up physical device test
9945d2b
Merge branch 'thomas/no-use-before-define' into thomas/reanimated
7c76154
doc fix
fac493f
fix crashes
8604c3c
onTransformWorklet works
6c2adfe
fix pageSheet modal breaking coordinates by removing originalPageX/Y …
b7b10af
fix missing gesture center logic
4427fcb
fix dx, dy
ebcb7b8
fix accessing props from worklets
77c9c80
refactor: clean up unused imports and simplify StaticPin component
d4fe8c0
fix longPress getting called on pinch
490ae19
add test case for modal mode
ff5b6c3
Zoomable context
elliottkember 8809509
Woo - no animated value in the consumer
elliottkember 3601884
Add a nice inverted zoom style
elliottkember fbab873
ConstantSizeMarker
elliottkember 44f0a85
Rename
elliottkember eea8cb1
unzoomStyle
elliottkember 1019845
pan responder hooks
341414d
runonjs (#154)
elliottkember f893a93
ref export
71fdaf9
Merge remote-tracking branch 'origin/thomas/reanimated' into thomas/r…
efdd4aa
unnecessary useAnimatedStyle
7846d04
onZoomEnd
74070c3
FixedSize
elliottkember e37a705
Revert math.max change in favour of separate PR
elliottkember 8c6b27f
Just expose inverseZoom, we don't need an animated style for a transform
elliottkember 86f67ca
inverseZoomStyle
elliottkember 4a2d93f
Separate context file
elliottkember a327775
Merge branch 'thomas/reanimated' into elliott/reanimated-context
elliottkember 591db01
Bugbot
elliottkember d23d301
Forgot a file
elliottkember 5193634
Merge pull request #153 from openspacelabs/elliott/reanimated-context
elliottkember 4545946
useZoomableViewContext
elliottkember f61f498
Forgot to export
elliottkember 678b1c2
Try it without the -worklet suffix and with a Worklet type (which tru…
elliottkember 1540cb2
Bump version
elliottkember File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ module.exports = function (api) { | |
| }, | ||
| }, | ||
| ], | ||
| 'react-native-reanimated/plugin', | ||
| ], | ||
| }; | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever! I think this should exhibit the same behaviour as the
react-navigation/react-native-screenspull to close, but I might add the routing library and someformSheet/pageSheetroutes just to test the theoryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 Looks good with
expo-router, which uses native-stack under the hood!