CI: Automatic changelog generation#156
CI: Automatic changelog generation#156thomasttvo wants to merge 11 commits intoci/build-on-releasefrom
Conversation
7ad51f4 to
8a6cc8b
Compare
8a6cc8b to
db264ae
Compare
b249d80 to
fc95161
Compare
- Extracts valid labels from release.yml using github-script - Requires at least one changelog label on PRs - Runs on label changes (labeled/unlabeled events)
fc95161 to
47556ee
Compare
- yq is pre-installed on GitHub runners - no need to install dependencies on every run
|
@claude please review this PR |
|
@claude review |
|
lib seems to be accidentally committed |
- Remove lib/commonjs/, lib/module/, lib/typescript/ from git tracking - Add lib/ to .gitignore - Remove bob build and git add lib from pre-commit hook (lib/ is built at publish time via react-native-builder-bob, not needed in repo) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughThis pull request removes the compiled library code from the repository, including all CommonJS and ES module implementations in Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
.github/workflows/pr-labels.yml (1)
3-5: Consider removingsynchronizetrigger.Label checks don't need to re-run on every push—only when labels change (
labeled,unlabeled) or PR opens/reopens. Thesynchronizetrigger causes unnecessary workflow runs on each commit.⚡ Reduce workflow runs
on: pull_request: - types: [opened, synchronize, reopened, labeled, unlabeled] + types: [opened, reopened, labeled, unlabeled]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/pr-labels.yml around lines 3 - 5, The pull_request trigger currently includes "synchronize", causing runs on every push; remove "synchronize" from the types array in the workflow so it only triggers on "opened", "reopened", "labeled", and "unlabeled" (update the types list in the top-level `on: pull_request:` block to exclude "synchronize").CONTRIBUTING.md (1)
91-102: Clarify that labels categorize release notes, not auto-bump versions.Lines 95-97 state labels trigger "major/minor/patch version bump," but these labels only categorize release notes—they don't automatically bump semver. The maintainer still chooses the version during
yarn release. Consider rewording to avoid confusion.📝 Suggested rewording
Release notes are automatically generated from merged pull requests. Please label your PRs with: -- `breaking`: Breaking changes (major version bump) -- `enhancement`: New features (minor version bump) -- `bug`: Bug fixes (patch version bump) +- `breaking`: Breaking changes +- `enhancement`: New features +- `bug`: Bug fixes - `documentation`: Documentation updates🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CONTRIBUTING.md` around lines 91 - 102, Update the "Changelog and Release Notes" section so it's clear that PR labels (`breaking`, `enhancement`, `bug`, `documentation`, `dependencies`) are used only to categorize release notes and do not automatically bump semver; explicitly state that the maintainer selects the version during the release process (e.g., when running `yarn release`) and that `.github/release.yml` controls note organization, not automatic versioning.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/pr-labels.yml:
- Around line 7-27: The check-labels job currently enforces labels for all PRs
and will block Dependabot PRs; update the workflow to skip this job or the
"Extract valid labels from release.yml" step when the actor is Dependabot by
adding an if condition that checks github.actor != 'dependabot[bot]' (reference
the job name check-labels and the step id extract-labels), so Dependabot PRs
bypass the labels requirement; alternatively, if you prefer allowing Dependabot
to be validated, include 'dependencies' in the labels set, but the recommended
quick fix is to add the if guard to skip the job/step for Dependabot.
In `@package.json`:
- Around line 116-119: The package.json is missing a "prepare" script so
release-it's npm publish may run without building lib/; add a "prepare" script
that runs the bob build step (e.g., set "prepare": "bob build") to ensure
react-native-builder-bob generates the lib/ directory before publishing—update
package.json's scripts section to include the prepare entry so the package is
built prior to npm publish triggered by the "github" / release-it configuration.
---
Nitpick comments:
In @.github/workflows/pr-labels.yml:
- Around line 3-5: The pull_request trigger currently includes "synchronize",
causing runs on every push; remove "synchronize" from the types array in the
workflow so it only triggers on "opened", "reopened", "labeled", and "unlabeled"
(update the types list in the top-level `on: pull_request:` block to exclude
"synchronize").
In `@CONTRIBUTING.md`:
- Around line 91-102: Update the "Changelog and Release Notes" section so it's
clear that PR labels (`breaking`, `enhancement`, `bug`, `documentation`,
`dependencies`) are used only to categorize release notes and do not
automatically bump semver; explicitly state that the maintainer selects the
version during the release process (e.g., when running `yarn release`) and that
`.github/release.yml` controls note organization, not automatic versioning.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ee2e1582-fb27-407e-8396-8be57e3d0def
⛔ Files ignored due to path filters (27)
lib/commonjs/ReactNativeZoomableView.js.mapis excluded by!**/*.maplib/commonjs/animations/index.js.mapis excluded by!**/*.maplib/commonjs/assets/pin.pngis excluded by!**/*.png,!**/*.pnglib/commonjs/components/AnimatedTouchFeedback.js.mapis excluded by!**/*.maplib/commonjs/components/StaticPin.js.mapis excluded by!**/*.maplib/commonjs/components/index.js.mapis excluded by!**/*.maplib/commonjs/debugHelper/index.js.mapis excluded by!**/*.maplib/commonjs/helper/applyPanBoundariesToOffset.js.mapis excluded by!**/*.maplib/commonjs/helper/calcNewScaledOffsetForZoomCentering.js.mapis excluded by!**/*.maplib/commonjs/helper/coordinateConversion.js.mapis excluded by!**/*.maplib/commonjs/helper/index.js.mapis excluded by!**/*.maplib/commonjs/index.js.mapis excluded by!**/*.maplib/commonjs/typings/index.js.mapis excluded by!**/*.maplib/module/ReactNativeZoomableView.js.mapis excluded by!**/*.maplib/module/animations/index.js.mapis excluded by!**/*.maplib/module/assets/pin.pngis excluded by!**/*.png,!**/*.pnglib/module/components/AnimatedTouchFeedback.js.mapis excluded by!**/*.maplib/module/components/StaticPin.js.mapis excluded by!**/*.maplib/module/components/index.js.mapis excluded by!**/*.maplib/module/debugHelper/index.js.mapis excluded by!**/*.maplib/module/helper/applyPanBoundariesToOffset.js.mapis excluded by!**/*.maplib/module/helper/calcNewScaledOffsetForZoomCentering.js.mapis excluded by!**/*.maplib/module/helper/coordinateConversion.js.mapis excluded by!**/*.maplib/module/helper/index.js.mapis excluded by!**/*.maplib/module/index.js.mapis excluded by!**/*.maplib/module/typings/index.js.mapis excluded by!**/*.mapyarn.lockis excluded by!**/yarn.lock,!**/*.lock,!**/yarn.lock
📒 Files selected for processing (43)
.github/release.yml.github/workflows/pr-labels.yml.gitignoreCONTRIBUTING.mdREADME.mdlib/commonjs/ReactNativeZoomableView.jslib/commonjs/animations/index.jslib/commonjs/components/AnimatedTouchFeedback.jslib/commonjs/components/StaticPin.jslib/commonjs/components/index.jslib/commonjs/debugHelper/index.jslib/commonjs/helper/applyPanBoundariesToOffset.jslib/commonjs/helper/calcNewScaledOffsetForZoomCentering.jslib/commonjs/helper/coordinateConversion.jslib/commonjs/helper/index.jslib/commonjs/index.jslib/commonjs/typings/index.jslib/module/ReactNativeZoomableView.jslib/module/animations/index.jslib/module/components/AnimatedTouchFeedback.jslib/module/components/StaticPin.jslib/module/components/index.jslib/module/debugHelper/index.jslib/module/helper/applyPanBoundariesToOffset.jslib/module/helper/calcNewScaledOffsetForZoomCentering.jslib/module/helper/coordinateConversion.jslib/module/helper/index.jslib/module/index.jslib/module/typings/index.jslib/typescript/ReactNativeZoomableView.d.tslib/typescript/__tests__/index.test.d.tslib/typescript/animations/index.d.tslib/typescript/components/AnimatedTouchFeedback.d.tslib/typescript/components/StaticPin.d.tslib/typescript/components/index.d.tslib/typescript/debugHelper/index.d.tslib/typescript/helper/applyPanBoundariesToOffset.d.tslib/typescript/helper/calcNewScaledOffsetForZoomCentering.d.tslib/typescript/helper/coordinateConversion.d.tslib/typescript/helper/index.d.tslib/typescript/index.d.tslib/typescript/typings/index.d.tspackage.json
💤 Files with no reviewable changes (36)
- lib/module/components/index.js
- lib/commonjs/components/index.js
- lib/typescript/components/AnimatedTouchFeedback.d.ts
- lib/typescript/helper/applyPanBoundariesToOffset.d.ts
- lib/module/animations/index.js
- lib/commonjs/typings/index.js
- lib/typescript/index.d.ts
- lib/typescript/helper/index.d.ts
- lib/commonjs/helper/applyPanBoundariesToOffset.js
- lib/commonjs/index.js
- lib/commonjs/animations/index.js
- lib/typescript/helper/calcNewScaledOffsetForZoomCentering.d.ts
- lib/module/components/AnimatedTouchFeedback.js
- lib/commonjs/debugHelper/index.js
- lib/module/components/StaticPin.js
- lib/module/ReactNativeZoomableView.js
- lib/commonjs/helper/calcNewScaledOffsetForZoomCentering.js
- lib/module/helper/index.js
- lib/commonjs/components/AnimatedTouchFeedback.js
- lib/commonjs/helper/index.js
- lib/commonjs/components/StaticPin.js
- lib/typescript/typings/index.d.ts
- lib/module/index.js
- lib/typescript/ReactNativeZoomableView.d.ts
- lib/module/helper/coordinateConversion.js
- lib/typescript/components/index.d.ts
- lib/typescript/helper/coordinateConversion.d.ts
- lib/typescript/components/StaticPin.d.ts
- lib/commonjs/helper/coordinateConversion.js
- lib/typescript/debugHelper/index.d.ts
- lib/module/typings/index.js
- lib/module/debugHelper/index.js
- lib/typescript/animations/index.d.ts
- lib/commonjs/ReactNativeZoomableView.js
- lib/module/helper/calcNewScaledOffsetForZoomCentering.js
- lib/module/helper/applyPanBoundariesToOffset.js
- Add prepare script (bob build) so lib/ is built before npm publish - Skip pr-labels check for dependabot[bot] actor Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ependabot" This reverts commit db49218.
This reverts commit ae88a40.
Dependabot PRs are excluded from release notes via release.yml authors field, so they don't need changelog labels. Without this, Dependabot PRs would be blocked by the required-labels check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary by CodeRabbit
Documentation
Chores