Skip to content

[codex] Combine separate predictor results#173

Merged
iskandr merged 17 commits into
masterfrom
combine-predictor-results
May 18, 2026
Merged

[codex] Combine separate predictor results#173
iskandr merged 17 commits into
masterfrom
combine-predictor-results

Conversation

@iskandr

@iskandr iskandr commented May 15, 2026

Copy link
Copy Markdown
Contributor

Closes #170.

Summary

  • Add combine_predictor_results() for stacking separate long-form predictor outputs into the same shape as a multi-model TopiaryPredictor run.
  • Preserve model-version provenance from fresh TopiaryPredictor DataFrame outputs via lightweight DataFrame.attrs metadata.
  • Validate matching (peptide, allele) identity sets and reject duplicate prediction_method_name values across inputs.
  • Keep emitted rows as the source of truth for which predictor produced which quantities: prediction_method_name, predictor_version, kind, and value/rank columns are not duplicated into kind_support metadata.
  • Preserve structured Metadata.extra values through TSV/CSV comment-block round trips using explicit JSON markers, with legacy kind_support parsing only for existing files that already wrote Python-dict-looking metadata.
  • Document the separate-run combine workflow and bump version to 5.16.2.

Validation

  • pytest tests/test_combine_predictor_results.py tests/test_io.py::TestParseCommentBlock tests/test_io.py::TestFormatCommentBlock
  • pytest tests/test_combine_predictor_results.py tests/test_result.py tests/test_io.py tests/test_io_pvacseq.py tests/test_kind_support.py tests/test_wide.py tests/test_best_allele.py
  • ./lint.sh
  • git diff --check
  • ./test.sh

@coveralls

coveralls commented May 15, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 89.828% (+0.001%) from 89.827% — combine-predictor-results into master

@iskandr iskandr marked this pull request as ready for review May 17, 2026 23:07
@iskandr iskandr merged commit ae94ce9 into master May 18, 2026
8 checks passed
@iskandr iskandr deleted the combine-predictor-results branch May 18, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combine predictions from separate TopiaryPredictor runs into one result

2 participants