Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Windows curl toolchain references to curl 8.19.0_4 to address vulnerability scanner findings and keep the Windows build/test environment aligned with the installed dependency.
Changes:
- Bump curl version/path in Windows build/test/setup batch scripts.
- Update curl version used by the Windows dependency installation script.
- Point Bazel/libgit2 and the
windows_curlWORKSPACE repository to the new curl directory.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
windows_test.bat |
Updates PATH to use curl-8.19.0_4 during Windows test runs. |
windows_setupvars.bat |
Updates PATH to use curl-8.19.0_4 for Windows build environment setup. |
windows_install_build_dependencies.bat |
Bumps curl_version to download/install 8.19.0_4. |
windows_create_package.bat |
Updates packaging license-copy paths to use the new curl directory (via variables). |
third_party/libgit2/libgit2_engine.bzl |
Updates libgit2’s Windows CURL_DEPENDENCIES_DIR to the new curl location. |
WORKSPACE |
Updates windows_curl local repository path to the new curl directory. |
| copy C:\opt\%curl_dir%\COPYING.txt %license_dest%LICENSE-CURL.txt | ||
| if !errorlevel! neq 0 exit /b !errorlevel! | ||
| copy C:\opt\curl-8.18.0_4-win64-mingw\dep\brotli\LICENSE.txt %license_dest%LICENSE-BROTIL.txt | ||
| copy C:\opt\%curl_dir%\dep\brotli\LICENSE.txt %license_dest%LICENSE-BROTIL.txt |
There was a problem hiding this comment.
The destination filename for the brotli license appears to be misspelled as LICENSE-BROTIL.txt. Since the source path is dep\brotli\..., this should likely be LICENSE-BROTLI.txt to avoid confusing/incorrect license naming in the package.
Suggested change
| copy C:\opt\%curl_dir%\dep\brotli\LICENSE.txt %license_dest%LICENSE-BROTIL.txt | |
| copy C:\opt\%curl_dir%\dep\brotli\LICENSE.txt %license_dest%LICENSE-BROTLI.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CVS-183418
Part of BDBA vulnerabilities, updating it to newest version
🧪 Checklist
``