Skip to content

Curl bump to 8.19.0#4086

Open
przepeck wants to merge 3 commits intomainfrom
przepeck/curl_8_19
Open

Curl bump to 8.19.0#4086
przepeck wants to merge 3 commits intomainfrom
przepeck/curl_8_19

Conversation

@przepeck
Copy link
Collaborator

🛠 Summary

CVS-183418
Part of BDBA vulnerabilities, updating it to newest version

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Windows curl toolchain references to curl 8.19.0_4 to address vulnerability scanner findings and keep the Windows build/test environment aligned with the installed dependency.

Changes:

  • Bump curl version/path in Windows build/test/setup batch scripts.
  • Update curl version used by the Windows dependency installation script.
  • Point Bazel/libgit2 and the windows_curl WORKSPACE repository to the new curl directory.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
windows_test.bat Updates PATH to use curl-8.19.0_4 during Windows test runs.
windows_setupvars.bat Updates PATH to use curl-8.19.0_4 for Windows build environment setup.
windows_install_build_dependencies.bat Bumps curl_version to download/install 8.19.0_4.
windows_create_package.bat Updates packaging license-copy paths to use the new curl directory (via variables).
third_party/libgit2/libgit2_engine.bzl Updates libgit2’s Windows CURL_DEPENDENCIES_DIR to the new curl location.
WORKSPACE Updates windows_curl local repository path to the new curl directory.

copy C:\opt\%curl_dir%\COPYING.txt %license_dest%LICENSE-CURL.txt
if !errorlevel! neq 0 exit /b !errorlevel!
copy C:\opt\curl-8.18.0_4-win64-mingw\dep\brotli\LICENSE.txt %license_dest%LICENSE-BROTIL.txt
copy C:\opt\%curl_dir%\dep\brotli\LICENSE.txt %license_dest%LICENSE-BROTIL.txt
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The destination filename for the brotli license appears to be misspelled as LICENSE-BROTIL.txt. Since the source path is dep\brotli\..., this should likely be LICENSE-BROTLI.txt to avoid confusing/incorrect license naming in the package.

Suggested change
copy C:\opt\%curl_dir%\dep\brotli\LICENSE.txt %license_dest%LICENSE-BROTIL.txt
copy C:\opt\%curl_dir%\dep\brotli\LICENSE.txt %license_dest%LICENSE-BROTLI.txt

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants